Added in cluster configuration support

[Bobbins228]

Issue link

Closes #255

What changes have been made

Changed the config check method to load the config file first and if it doesn't work it will try load the in cluster configuration.

Verification steps

• From the terminal run in the codeflare-sdk directory poetry build
• In a cluster go to the Open Datahub dashboard
• Create a codeflare Jupytr notebook
• uninstall the current codeflare-sdk with pip uninstall codeflare-sdk -y
• Drag and drop the build into the Jupyter notebook
• Install the build with pip install codeflare_sdk-0.0.0.dev0-py3-none-any.whl
• Restart the Notebook kernel
• Run through a demo notebook without logging in with token + server (This is important because it affects how config files are loaded)
• cluster.up() should work without a kubernetes config file and default to using the incluster_config

Checks

• I've made sure the tests are passing.
• Testing Strategy
  • Unit tests
  • Manual tests
  • Testing is not required for this change

[MichaelClifford]

Anyway to avoid this nested try/except statement? Can we check that we are in the cluster before trying to load the config?

[Bobbins228]

Added a check to see if the config file exists and if not a check to see if we are in the cluster before using load_incluster_config

[MichaelClifford]

Thanks I think that's much better. I'll test it this morning.

[Maxusmusti]

Looks good, just one change needed for error handling

[Maxusmusti]

I think this needs to raise a PermissionsError instead of just printing. Either that, or we need to catch the ConnectionRefusedError/MaxRetryError caused by this later down the road with the Kubernetes API. Since we are no longer blocking here, we are currently getting:

MaxRetryError: HTTPConnectionPool(host='localhost', port=80): Max retries exceeded with url: /apis/mcad.ibm.com/v1beta1/namespaces/openshift-operators/appwrappers (Caused by NewConnectionError(': Failed to establish a new connection: [Errno 61] Connection refused'))

instead of:

PermissionError: Action not permitted, have you put in correct/up-to-date auth credentials?

on various API calls

[kpouget]

@Bobbins228 I rebased the PR 😅
I didn't expected Github to allow me to do it, but it worked 🙃
anyway, I'll launch a test with this up to date PR, I needed the branch to be up to date to be able to test it

[kpouget]

@Bobbins228 FYI, this PR worked with my in-cluster script using codeflare SDK :)

[Maxusmusti]

Looks good, just one more error handling suggestion

[Maxusmusti]

LGTM

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Maxusmusti

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [Maxusmusti]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment