Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Dashboard URI returned by cluster.status() #317

Conversation

ChristianZaccaria
Copy link
Collaborator

@ChristianZaccaria ChristianZaccaria commented Aug 21, 2023

Issue link

Closes #316

What changes have been made

This change fixes the issue where the hyperlink provided by the cluster.status() method is incorrect.

Previously the hyperlink provided resolved to a relative path as opposed to the absolute Ray Dashboard URI. For this reason, I prefixed http:// to ensure the hyperlink points to the correct URI.

Verification steps

  1. In a cluster go to the Open Datahub dashboard and create a Jupyter Notebook
  2. Uninstall the current codeflare-sdk with pip uninstall codeflare-sdk -y
  3. Install the codeflare-sdk from this branch: You will need to run poetry build to generate a wheel of the SDK.
  4. Upload the wheel to the Jupyter Notebook, and install the build with pip install codeflare_sdk-0.0.0.dev0-py3-none-any.whl.
  5. Restart the Notebook Kernel
  6. Run through one of the guided-demos i.e.: 0_basic_ray.ipynb
  7. When running through the demo, after running cluster.status() you can attempt to open the Ray Dashboard through the provided hyperlink.

Checks

  • Testing Strategy
    • Manual tests

Copy link
Collaborator

@KPostOffice KPostOffice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment

src/codeflare_sdk/cluster/cluster.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@KPostOffice KPostOffice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 23, 2023
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Aug 30, 2023
@KPostOffice
Copy link
Collaborator

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 30, 2023
Copy link
Collaborator

@MichaelClifford MichaelClifford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 30, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: KPostOffice, MichaelClifford

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 30, 2023
@openshift-merge-robot openshift-merge-robot merged commit c30f747 into project-codeflare:main Aug 30, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect Dashboard URI returned by cluster.status() method
4 participants