-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Dashboard URI returned by cluster.status() #317
Fix Dashboard URI returned by cluster.status() #317
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One comment
3084088
to
ad18a3f
Compare
ad18a3f
to
41fdba9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: KPostOffice, MichaelClifford The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
c30f747
into
project-codeflare:main
Issue link
Closes #316
What changes have been made
This change fixes the issue where the hyperlink provided by the cluster.status() method is incorrect.
Previously the hyperlink provided resolved to a relative path as opposed to the absolute Ray Dashboard URI. For this reason, I prefixed
http://
to ensure the hyperlink points to the correct URI.Verification steps
poetry build
to generate a wheel of the SDK.pip install codeflare_sdk-0.0.0.dev0-py3-none-any.whl
.Checks