Refactor unit tests to eliminate pytest warnings #322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-merge-robot
added
the
needs-rebase
Bobbins228
requested changes
Aug 23, 2023
ChristianZaccaria
force-pushed
the
fix-warnings-unittests
branch
from
d04882e
to
041349e
Compare
openshift-merge-robot
removed
the
needs-rebase
- Refactored to remove return statements from the tests that are ran. - Created the respective support functions. - Silenced warnings that originate from pkg_resources.
ChristianZaccaria
force-pushed
the
fix-warnings-unittests
branch
from
041349e
to
db9ebb3
Compare
Awesome, thanks for testing and reviewing! It's now rebased. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Bobbins228, Maxusmusti The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
openshift-merge-robot
merged commit 61d7f3b
into
project-codeflare:main
2 checks passed
| @@ -66,6 +66,14 @@ | |||
| export_env, | |||
| ) | |||
|
|
|||
| from tests.unit_test_support import ( | |||
There was a problem hiding this comment.
I think you need to add an empty __init__.py file to tests/ so that you can import it this way.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue link
Closes #321
Cause of Warnings
7 of the warnings arise from tests that include a return statement. It seems these should only be making assertions and not returning anything. This way, pytest won't display any warnings.
The 4 other warnings are related to pkg_resources deprecation. I am unsure where this is coming from (it's not in the repo), it seems like an indirect library call:
Based on this GitHub issue on google-cloud-python and this PR on ibis repo, it seems people are inclined to silence these warnings for the meantime.
Changes
Verification steps
pip install -e .pytest -v tests/unit_test.pyChecks