Updated AW API Group to codeflare.dev #341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dimakis
reviewed
Sep 7, 2023
There was a problem hiding this comment.
@Maxusmusti I still see some mcad.ibm.com strings in docs, namely:
- awload.html
- cluster.html
- generate_yaml.html
should these be changed too?
|
@dimakis the docs will be updated when a new release is triggered, so no need to change those manually |
dimakis
approved these changes
Sep 7, 2023
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dimakis, MichaelClifford The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
astefanutti
reviewed
Sep 8, 2023
| @@ -1,4 +1,4 @@ | |||
| apiVersion: mcad.ibm.com/v1beta1 | |||
| apiVersion: codeflare.dev/v1beta1 | |||
There was a problem hiding this comment.
This should be workload.codeflare.dev.
| @@ -33,7 +33,7 @@ spec: | |||
| kind: RayCluster | |||
| metadata: | |||
| labels: | |||
| appwrapper.mcad.ibm.com: gptfttest | |||
| appwrapper.codeflare.dev: gptfttest | |||
There was a problem hiding this comment.
The labels haven't changed (yet).
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue link
#272
What changes have been made
API groups for AW changed from mcad.ibm.com to codeflare.dev
Verification steps
Verify no remaining files with mcad.ibm.com, and all have switched to codeflare.dev
Checks