Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: update python to v3.9 and ray to v2.7 #377

Merged
merged 1 commit into from
Oct 10, 2023
Merged

Conversation

dimakis
Copy link
Contributor

@dimakis dimakis commented Oct 10, 2023

Issue link

closes #371

What changes have been made

Update python and ray versions

Verification steps

  1. Checkout PR
  2. Build python wheel using poetry build. Wheel should be in the dist folder.
  3. Install the wheel on your cluster
  4. run through the demo notebooks
  5. the nbs should run as expected

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • Testing is not required for this change

@dimakis
Copy link
Contributor Author

dimakis commented Oct 10, 2023

@KPostOffice @MichaelClifford

I've not had time to update the entire code, this is the image rayproject/ray:latest-py39-cu118

but I've tested it with 3 demo notebooks

Copy link
Contributor

@Bobbins228 Bobbins228 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested this out on multiple notebooks including local_interactive and works as intended.
Ray ver is 2.7 as expected and the custom ray image works for me.
Good stuff
/LGTM

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 10, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 10, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Bobbins228

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 10, 2023
@openshift-ci openshift-ci bot merged commit 9c8c9fa into main Oct 10, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Python version in SDK to 3.9
2 participants