-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make ray image parameter as optional #594
Make ray image parameter as optional #594
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/hold
This lgtm its just we need to hold it until after release when the new SDK version includes the optional image parameter.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small nit
demo-notebooks/guided-demos/notebook-ex-outputs/1_cluster_job_client.ipynb
Outdated
Show resolved
Hide resolved
09a6352
to
e6c7594
Compare
/lgtm @Bobbins228 if I understand your concern correctly, I think we should rather move users away from relying on the main branch, rather than holding changes? |
@astefanutti That is a great idea! I did have concerns about what this current flow would be like in terms of getting source code of a specific release only to find the notebooks are outdated. Huge +1 on this. We might need to coordinate with docs when we go through with it. |
thinking, would it have sense to reference users to use tags for sample notebooks? |
Im happy for this to be merged after rebasing when #605 is merged |
e6c7594
to
f1fc7f4
Compare
src/codeflare_sdk/demo-notebooks/guided-demos/2_basic_interactive.ipynb
Outdated
Show resolved
Hide resolved
f1fc7f4
to
9230a0f
Compare
/unhold #605 has been merged. |
/lgtm |
/approve |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: astefanutti, Bobbins228 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
029683f
into
project-codeflare:main
Issue link
https://issues.redhat.com/browse/RHOAIENG-10006
What changes have been made
With the new UBI9 based ray runtime image
quay.io/rhoai/ray:2.23.0-py39-cu121
used as default in codeflare-sdk raycluster-configuration, updating references of image parameter as optional inVerification steps
Checks