rm default namespace from demo notebooks #597
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tests are failing |
|
/retest |
Bobbins228
requested changes
Jul 22, 2024
KPostOffice
force-pushed
the
rhoaieng-7554
branch
from
f5b5c8d
to
7d48a0a
Compare
Ygnas
approved these changes
Jul 22, 2024
Bobbins228
previously requested changes
Jul 22, 2024
Signed-off-by: Kevin <[email protected]>
KPostOffice
force-pushed
the
rhoaieng-7554
branch
from
eb26fd3
to
661f815
Compare
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Fiona-Waters, Ygnas The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
Fiona-Waters
dismissed
Bobbins228’s stale review
Requested changes have already been applied and lgtm added by Mark.
openshift-merge-bot
bot
merged commit f100ba1
into
project-codeflare:main
4 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue link
https://issues.redhat.com/browse/RHOAIENG-7554
What changes have been made
Remove namespace param from example notebooks
Verification steps
Checks