UI visual regression testing to cover UI widgets visibility #674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
the
do-not-merge/work-in-progress
Ygnas
force-pushed
the
RHOAIENG-12525
branch
from
1e9e7d8
to
1ad654b
Compare
openshift-merge-robot
added
the
needs-rebase
Ygnas
force-pushed
the
RHOAIENG-12525
branch
from
1ad654b
to
875268d
Compare
openshift-merge-robot
removed
the
needs-rebase
Ygnas
force-pushed
the
RHOAIENG-12525
branch
from
875268d
to
2128799
Compare
openshift-merge-robot
added
the
needs-rebase
Ygnas
force-pushed
the
RHOAIENG-12525
branch
from
2128799
to
5d17d5e
Compare
openshift-merge-robot
removed
the
needs-rebase
Ygnas
force-pushed
the
RHOAIENG-12525
branch
7 times, most recently
from
942fb9f
to
89ac3c3
Compare
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
openshift-ci
bot
requested review from
ChristianZaccaria and
MichaelClifford
Ygnas
requested review from
KPostOffice and
Bobbins228
and removed request for
MichaelClifford
KPostOffice
reviewed
Sep 19, 2024
Ygnas
force-pushed
the
RHOAIENG-12525
branch
6 times, most recently
from
baf4658
to
cee54a1
Compare
Ygnas
force-pushed
the
RHOAIENG-12525
branch
2 times, most recently
from
10f4d97
to
d1ae990
Compare
Ygnas
force-pushed
the
RHOAIENG-12525
branch
2 times, most recently
from
bde3957
to
3e07369
Compare
Ygnas
added
test-ui-notebooks
KPostOffice
reviewed
Sep 20, 2024
KPostOffice
reviewed
Sep 20, 2024
Ygnas
force-pushed
the
RHOAIENG-12525
branch
from
3e07369
to
92ae183
Compare
Ygnas
added
test-ui-notebooks
KPostOffice
approved these changes
Sep 23, 2024
openshift-ci
bot
added
lgtm
Ygnas
force-pushed
the
RHOAIENG-12525
branch
from
92ae183
to
be9b9a5
Compare
Ygnas
dismissed
Bobbins228’s stale review
Dismissing as everything is resolved.
Ygnas
added
test-ui-notebooks
KPostOffice
approved these changes
Sep 23, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: KPostOffice The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit 2e5ee98
into
project-codeflare:main
12 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue link
https://issues.redhat.com/browse/RHOAIENG-12525
Depends on:
What changes have been made
Added I visual regression testing to cover UI widgets visibility
Verification steps
Passing tests.
At the moment I have made a separate workflow but I think it would be best to integrate them into the guided notebook tests, as my workflow is almost identical to that one.
Checks