-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor Ray and AppWrapper modules #695
Refactor Ray and AppWrapper modules #695
Conversation
The split looks good overall! 👍 |
993cea1
to
44e45e5
Compare
44e45e5
to
174f9db
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ran through an imports diagnostic tool, looks great! - Just left one comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Signed-off-by: Bobbins228 <[email protected]>
Signed-off-by: Bobbins228 <[email protected]>
174f9db
to
be8582a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this a breaking change @varshaprasad96 ? Do we need to maintain the current imports for a few releases?
This is a breaking change, but we are going to continue to support the API functionality as is - so it should not be a requirement to maintain the import paths. Specifying in the changelog and mentioning it in the documentation should be enough. |
Heard that. I wasn't sure if we had any obligations for it to be exactly the same import path. I'm good then |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: KPostOffice, Ygnas The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
92a8961
into
project-codeflare:main
Issue link
Closes: RHOAIENG-13332
What changes have been made
Refactored the Ray and Appwrapper modules to fit the design doc
Verification steps
E2E and Unit tests should be sufficient
Checks