Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Ray and AppWrapper modules #695

Merged
merged 2 commits into from
Oct 3, 2024

Conversation

Bobbins228
Copy link
Contributor

Issue link

Closes: RHOAIENG-13332

What changes have been made

Refactored the Ray and Appwrapper modules to fit the design doc

Verification steps

E2E and Unit tests should be sufficient

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • Testing is not required for this change

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 1, 2024
@Bobbins228 Bobbins228 added test-guided-notebooks Run PR check to verify Guided notebooks test-ui-notebooks Run PR check to verify UI notebooks labels Oct 1, 2024
@varshaprasad96
Copy link
Contributor

The split looks good overall! 👍

@Ygnas Ygnas mentioned this pull request Oct 2, 2024
5 tasks
@Bobbins228 Bobbins228 added test-guided-notebooks Run PR check to verify Guided notebooks test-ui-notebooks Run PR check to verify UI notebooks and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. test-guided-notebooks Run PR check to verify Guided notebooks test-ui-notebooks Run PR check to verify UI notebooks labels Oct 2, 2024
@Bobbins228 Bobbins228 changed the title [WIP] Refactor Ray and AppWrapper modules Refactor Ray and AppWrapper modules Oct 2, 2024
@Bobbins228 Bobbins228 added test-guided-notebooks Run PR check to verify Guided notebooks and removed test-guided-notebooks Run PR check to verify Guided notebooks test-ui-notebooks Run PR check to verify UI notebooks labels Oct 2, 2024
Copy link
Collaborator

@ChristianZaccaria ChristianZaccaria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran through an imports diagnostic tool, looks great! - Just left one comment

src/codeflare_sdk/ray/cluster/generate_yaml.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@ChristianZaccaria ChristianZaccaria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 2, 2024
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Oct 2, 2024
@Bobbins228 Bobbins228 added lgtm Indicates that a PR is ready to be merged. test-guided-notebooks Run PR check to verify Guided notebooks and removed test-guided-notebooks Run PR check to verify Guided notebooks labels Oct 2, 2024
Copy link
Collaborator

@KPostOffice KPostOffice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this a breaking change @varshaprasad96 ? Do we need to maintain the current imports for a few releases?

src/codeflare_sdk/ray/appwrapper/awload.py Show resolved Hide resolved
@varshaprasad96
Copy link
Contributor

Do we need to maintain the current imports for a few releases?

This is a breaking change, but we are going to continue to support the API functionality as is - so it should not be a requirement to maintain the import paths. Specifying in the changelog and mentioning it in the documentation should be enough.

@KPostOffice
Copy link
Collaborator

Do we need to maintain the current imports for a few releases?

This is a breaking change, but we are going to continue to support the API functionality as is - so it should not be a requirement to maintain the import paths. Specifying in the changelog and mentioning it in the documentation should be enough.

Heard that. I wasn't sure if we had any obligations for it to be exactly the same import path. I'm good then

Copy link
Contributor

openshift-ci bot commented Oct 3, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: KPostOffice, Ygnas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 3, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 92a8961 into project-codeflare:main Oct 3, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. test-guided-notebooks Run PR check to verify Guided notebooks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants