-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: codeflare sdk unit tests #702
refactor: codeflare sdk unit tests #702
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #702 +/- ##
==========================================
+ Coverage 91.30% 93.99% +2.69%
==========================================
Files 23 36 +13
Lines 1299 2364 +1065
==========================================
+ Hits 1186 2222 +1036
- Misses 113 142 +29 ☔ View full report in Codecov by Sentry. |
fafcb62
to
e45ee2d
Compare
dbfb2b8
to
50aa705
Compare
sort unit tests into individual files and made minor enhancements
50aa705
to
3d5a99d
Compare
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: KPostOffice The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
7694218
into
project-codeflare:main
sort unit tests into individual files and made minor enhancements
Issue link
Closes: RHOAIENG-13847
What changes have been made
unit_test.py
get_ray_obj
andget_aw_obj
related helper functions (No more full RayCluster/AppWrapper yamls in a test file!!!)ClusterConfiguration
related tests into one test that tests all parameters (instead of multiple smaller tests that test 1 or 2)Verification steps
poetry shell
poetry install --with test,docs
coverage run -m --source=src pytest src/codeflare_sdk --ignore=src/codeflare_sdk/common/utils/unit_test_support.py
coverage report
orcoverage report -m | tail -1 | tail -c 4
Checks