Dynamic notebooks sync workflow #705
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #705 +/- ##
=======================================
Coverage 93.99% 93.99%
=======================================
Files 36 36
Lines 2364 2364
=======================================
Hits 2222 2222
Misses 142 142 ☔ View full report in Codecov by Sentry. |
openshift-ci
bot
added
the
do-not-merge/hold
ChristianZaccaria
force-pushed
the
dynamic-notebook-sync-workflow
branch
from
abb133e
to
802144b
Compare
ChristianZaccaria
force-pushed
the
dynamic-notebook-sync-workflow
branch
from
802144b
to
026a326
Compare
Bobbins228
reviewed
Oct 14, 2024
|
@Bobbins228 yes, I was testing for py3.11. I added the workflow run and PR generated for that now. Thanks! |
ChristianZaccaria
removed
the
do-not-merge/hold
Ygnas
approved these changes
Oct 14, 2024
KPostOffice
approved these changes
Oct 14, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: KPostOffice, Ygnas The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
openshift-merge-bot
bot
merged commit 7c04444
into
project-codeflare:main
14 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue link
Related Jira: https://issues.redhat.com/browse/RHOAIENG-14201
Jira: https://issues.redhat.com/browse/RHOAIENG-14203
What changes have been made
With this change, we can dispatch the notebooks sync workflow by also providing the specific python version and target branch name, i.e., release-2024a for Notebooks with py3.9.
Additionally, pipenv version has been pinned to use version
2024.0.3as latest version2024.1.0seems to break the workflow. I added a TODO to retry on later major/minor versions of pipenv once available.Verification steps
Workflow run for py3.9: https://github.com/project-codeflare/codeflare-sdk/actions/runs/11324720561
Generated PR for py3.9 in my fork: ChristianZaccaria/notebooks#3
Workflow run for py3.11: https://github.com/project-codeflare/codeflare-sdk/actions/runs/11325885485/job/31493695580
Generated PR for py3.11 in my fork: ChristianZaccaria/notebooks#4
Checks