Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance ray module code documentation #744

Merged
merged 2 commits into from
Nov 12, 2024

Conversation

Ygnas
Copy link
Contributor

@Ygnas Ygnas commented Oct 29, 2024

Issue link

https://issues.redhat.com/browse/RHOAIENG-13959

What changes have been made

Enhanced ray module code documentation

Verification steps

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • Testing is not required for this change

@Ygnas Ygnas requested review from KPostOffice, Bobbins228 and ChristianZaccaria and removed request for astefanutti and dimakis October 29, 2024 13:49
Copy link

codecov bot commented Oct 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.05%. Comparing base (9af07a0) to head (fdfabfb).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #744      +/-   ##
==========================================
+ Coverage   93.00%   93.05%   +0.04%     
==========================================
  Files          36       36              
  Lines        2403     2403              
==========================================
+ Hits         2235     2236       +1     
+ Misses        168      167       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Ygnas Ygnas changed the title docs: enhance ray module code documentation Enhance ray module code documentation Oct 29, 2024
@Ygnas Ygnas added test-ui-notebooks Run PR check to verify UI notebooks and removed test-ui-notebooks Run PR check to verify UI notebooks labels Nov 11, 2024
Copy link
Collaborator

@KPostOffice KPostOffice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small comment

src/codeflare_sdk/ray/client/ray_jobs.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@KPostOffice KPostOffice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 11, 2024
src/codeflare_sdk/ray/cluster/config.py Outdated Show resolved Hide resolved
src/codeflare_sdk/ray/cluster/config.py Outdated Show resolved Hide resolved
src/codeflare_sdk/ray/cluster/config.py Outdated Show resolved Hide resolved
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Nov 12, 2024
Copy link
Contributor

@Bobbins228 Bobbins228 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm /approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 12, 2024
Copy link
Contributor

openshift-ci bot commented Nov 12, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Bobbins228

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 12, 2024
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Nov 12, 2024
@Bobbins228
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 12, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 70d453d into project-codeflare:main Nov 12, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants