Update python tests job #88
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anishasthana
force-pushed
the
update_unit_tests_job
branch
from
8f843b9
to
280a5ec
Compare
anishasthana
force-pushed
the
update_unit_tests_job
branch
from
280a5ec
to
2089633
Compare
anishasthana
force-pushed
the
update_unit_tests_job
branch
2 times, most recently
from
b19ede0
to
30a38ce
Compare
KPostOffice
reviewed
May 11, 2023
anishasthana
force-pushed
the
update_unit_tests_job
branch
from
30a38ce
to
9f1bb2a
Compare
KPostOffice
reviewed
May 11, 2023
anishasthana
force-pushed
the
update_unit_tests_job
branch
2 times, most recently
from
6a80d34
to
f4a710e
Compare
KPostOffice
reviewed
May 11, 2023
Signed-off-by: Anish Asthana <[email protected]>
anishasthana
force-pushed
the
update_unit_tests_job
branch
from
f4a710e
to
0742d19
Compare
jiripetrlik
reviewed
Jun 8, 2023
| RUN dnf install nodejs -y && \ | ||
| dnf clean all && \ | ||
| rm -rf /var/cache/dnf | ||
| ADD https://mirror.openshift.com/pub/openshift-v4/clients/oc/latest/linux/oc.tar.gz $TMPDIR/ |
There was a problem hiding this comment.
I think that if we use ADD here, the Docker will create a separate image layer with tar file. And even if we delete it in the next command it will stay in the image. It will be only hidden by next layer. I would suggest to download tar with oc as part of the RUN command on next line.
|
@KPostOffice and I connected -- I will spend some time updating this PR to have the repo be fully based on poetry (no requirements.txt) |
|
Replaced by #305 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.