Add use of priorityClasses to SDK #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaelClifford
force-pushed
the
priority
branch
6 times, most recently
from
0dd96cc
to
98767c7
Compare
asm582
requested changes
Apr 27, 2023
MichaelClifford
force-pushed
the
priority
branch
from
dfdbac1
to
b4c059f
Compare
|
@asm582 Do you want to give this another look and approve the changes requested? |
KPostOffice
reviewed
Jun 16, 2023
MichaelClifford
force-pushed
the
priority
branch
from
b4c059f
to
29c04a1
Compare
|
Thanks for the comments @KPostOffice . updated 😄 @asm582 Do you want to give this another look and resolve any outstanding comments 😄 |
MichaelClifford
force-pushed
the
priority
branch
from
29c04a1
to
ad124ea
Compare
KPostOffice
reviewed
Jun 20, 2023
MichaelClifford
force-pushed
the
priority
branch
5 times, most recently
from
db09cf3
to
ced41ab
Compare
|
LGTM, priority levels for now are hardcoded in some way, in the future users may need fewer or more priority levels. |
asm582
approved these changes
Jun 22, 2023
Maxusmusti
reviewed
Jun 22, 2023
MichaelClifford
force-pushed
the
priority
branch
from
ced41ab
to
59c8673
Compare
MichaelClifford
force-pushed
the
priority
branch
from
59c8673
to
20e6d93
Compare
MichaelClifford
force-pushed
the
priority
branch
from
8f08a9d
to
d87a056
Compare
MichaelClifford
changed the title
MichaelClifford
force-pushed
the
priority
branch
from
d87a056
to
0ecf145
Compare
|
@MichaelClifford Checked this is approved, please feel free to merge |
openshift-merge-robot
added
the
needs-rebase
MichaelClifford
force-pushed
the
priority
branch
from
0ecf145
to
8761a17
Compare
openshift-merge-robot
removed
the
needs-rebase
MichaelClifford
force-pushed
the
priority
branch
from
8761a17
to
e09cdf7
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: asm582, Maxusmusti The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
openshift-merge-robot
merged commit e6d9f76
into
project-codeflare:main
2 checks passed
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables the use of
PriorityClassesfor our RayClusters.closes #182
dispatch_prioritytoClusterConfigdispatch_priorityis left empty, appwrapper is not affected.dispatch_priorityis used, then appwrapper adds the fieldpriorityClassNameto the head and worker group specs.cluster.up(). This addition is required as not all values fordispatch_priorityare valid and the cluster needs to be checked for valid values before applying the appwrapper.