Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix is_dollar_amount() to accept strings cast from single precision floats. Ensure no mixed dtypes before to_parquet() #107

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

radkoff
Copy link

@radkoff radkoff commented Dec 12, 2020

Two fixes here

  1. This issue
  2. Some dollar amounts are cast to strings from single-precision floats (e.g. 10.5 instead of 10.51), and the existing is_dollar_amount does not recognize it. This means a perfect match is not detected in dollar_match(), which was causing my results to be much lower than expected. I saw it happening in your baseline results too (❌ gross_amount: guessed "$1,510.00" with score 0.903, was actually "$1,510.0" ), so if you guys pull this and rerun, you should see a higher score for gross_amount

…loats. Ensure no mixed dtypes before to_parquet().
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant