Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's a much larger patchset than I would like, but one thing required another thing, and another thing, and... you get the idea.
Overview
On server startup:
Fuyu/Accounts/
How registration works:
accountId
isint
, The account registration will find gaps in ids and fill automaticallyHow login works:
MongoId
)On EFT wipe profile:
Other changes
fuyu
) is onlocalhost:8000
and EFT Main server (eft-main
) is onlocalhost:8001
start server
button is gone. I think having a separate server management tool is betterNotes
I am using multi-threading whever possible as I want Fuyu to account for large-scale systems and for machines with many cores (most EFT players have high-end systems to run the game with at least 12 virtual threads available).
Discussion
I personally do not like
AccountTable
loading in the accounts fromAccountTable.Load
, maybe a separateDatabaseSourceProvider
or something needs to be created that populated the database on load. This way the database is not responsible for both holding the data and providing sources.I noticed that
ConcurrentDictionary<T>
andConcurrentBag<T>
are much faster than manual locking. I'll remove the locking system in a separate patch, and replaceDictionary<T>
/List<T>
with their threadsafe counterparts respectively.I think I want EFT's servers to run on
localhost:801x
and Arena's servers onlocalhost:802x
.The launcher really needs some work but I'm absolutely crap at it. I want a login/register/account/settings screen relatively simular to that of SPT's. The workflow is rather nice, but it would be nice to support a server list so users can select the server they want to use (in case they want to play on multiple different servers)