Rework HttpControllers #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seionmoya
added
enhancement
seionmoya
requested changes
Oct 8, 2024
There was a problem hiding this comment.
I like the work but not the type name.
I think HttpDataController would work better for me.
@TheSpartaPT @Lacyway suggestions?
…hy it didn't cross my mind to begin with
seionmoya
approved these changes
Oct 9, 2024
|
Resolved by changing |
seionmoya
requested changes
Oct 13, 2024
seionmoya
approved these changes
Oct 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added the class
BodyAwareHttpController<TRequest>which works just as theItemEventController<TEvent>does just as @seionmoya and I discussed.Instead of inheriting from HttpController for your route and getting the body from the context within
RunAsyncyou can instead inherit fromBodyAwareHttpControllerand use the generic to put your expected body type.I have converted all existing usages of
context.GetJsonAsync<T>to instead useBodyAwareHttpController<T>.