Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a validating webhook to EdgeDevice #125

Merged
merged 1 commit into from
May 18, 2022
Merged

Add a validating webhook to EdgeDevice #125

merged 1 commit into from
May 18, 2022

Conversation

rgolangh
Copy link
Collaborator

@rgolangh rgolangh commented Mar 7, 2022 •
edited
Loading

Prevent irrelevant or conflicting device specifications.

Signed-off-by: Roy Golan [email protected]

ECOPROJECT-347

jakub-dzon
jakub-dzon requested changes Mar 7, 2022
View reviewed changes
api/v1alpha1/edgedevice_webhook.go Outdated Show resolved Hide resolved
config/default/webhookcainjection_patch.yaml Outdated Show resolved Hide resolved
api/v1alpha1/edgedevice_webhook_test.go Show resolved Hide resolved
api/v1alpha1/edgedevice_webhook_test.go Show resolved Hide resolved
config/webhook/manifests.yaml Outdated Show resolved Hide resolved
@rgolangh rgolangh changed the title Add a validating webhook to EdgeDevice WIP: Add a validating webhook to EdgeDevice Mar 7, 2022
@rgolangh rgolangh marked this pull request as draft March 7, 2022 16:51
@rgolangh rgolangh marked this pull request as ready for review March 7, 2022 17:12
@rgolangh rgolangh force-pushed the webhook-edgedevice branch 2 times, most recently from a14209a to 8ded868 Compare March 7, 2022 17:13
masayag
masayag reviewed Mar 7, 2022
View reviewed changes
config/default/manager_webhook_patch.yaml Outdated Show resolved Hide resolved
PROJECT Show resolved Hide resolved
config/webhook/manifests.yaml Show resolved Hide resolved
rgolangh
rgolangh commented Mar 15, 2022
View reviewed changes
main.go Outdated Show resolved Hide resolved
@jakub-dzon jakub-dzon mentioned this pull request Mar 28, 2022
Merged
@jakub-dzon
Copy link
Collaborator

@rgolangh - how is the work going on that feature? It seems to be needed for #148.

@rgolangh rgolangh force-pushed the webhook-edgedevice branch 4 times, most recently from 4d5d533 to 9889bf5 Compare April 7, 2022 13:07
@pkliczewski
Copy link
Collaborator

@rgolangh will you be able to finalize this PR?

@rgolangh rgolangh changed the title WIP: Add a validating webhook to EdgeDevice Add a validating webhook to EdgeDevice Apr 18, 2022
@rgolangh rgolangh force-pushed the webhook-edgedevice branch 7 times, most recently from a7b411b to bc155b9 Compare May 16, 2022 13:24
pkliczewski
pkliczewski reviewed May 18, 2022
View reviewed changes
Copy link
Collaborator

@pkliczewski pkliczewski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@masayag masayag merged commit b59a5f6 into project-flotta:main May 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pkliczewski pkliczewski pkliczewski left review comments

@jakub-dzon jakub-dzon jakub-dzon approved these changes

@masayag masayag masayag approved these changes

@eloycoto eloycoto Awaiting requested review from eloycoto

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rgolangh @jakub-dzon @pkliczewski @masayag