-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce PNC 2.0 Rest client #2
Conversation
Migrate to 2.0 Break the code to be easily readable There is a bunch of TODOs for other parts, which must be solved
@dwalluck Hi, it is a good time for you to review my changed. I followed these steps:
What's missing?
I hope it won't be too big shock for you and you will like it :-) |
Codecov Report
@@ Coverage Diff @@
## master #2 +/- ##
=======================================
Coverage 48.76% 48.76%
=======================================
Files 35 35
Lines 2998 2998
Branches 365 365
=======================================
Hits 1462 1462
Misses 1379 1379
Partials 157 157 Continue to review full report at Codecov.
|
core/src/main/java/org/jboss/pnc/build/finder/core/PncBuildFinder.java
Outdated
Show resolved
Hide resolved
@dwalluck Both methods are used now. |
|
||
private DummyPncClient dummyPncClient; | ||
|
||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is kind of strange to initialize here, no? I guess the only alternative is to make them static? JUnit has a @BeforeClass
but it must be a static method.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think, it doesn't matter in this case as it is a test class, which should have only one instance anyway. I did it this way for some reason, which I cannot recall right now :-D
No description provided.