Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make report renderText() return Optional #211

Merged
merged 1 commit into from
Sep 9, 2020

Conversation

dwalluck
Copy link
Collaborator

@dwalluck dwalluck commented Sep 9, 2020

No description provided.

@codecov
Copy link

codecov bot commented Sep 9, 2020

Codecov Report

Merging #211 into master will increase coverage by 0.03%.
The diff coverage is 90.90%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #211      +/-   ##
============================================
+ Coverage     68.99%   69.02%   +0.03%     
  Complexity      619      619              
============================================
  Files            38       38              
  Lines          3032     3035       +3     
  Branches        376      376              
============================================
+ Hits           2092     2095       +3     
  Misses          764      764              
  Partials        176      176              
Impacted Files Coverage Δ Complexity Δ
...java/org/jboss/pnc/build/finder/report/Report.java 95.00% <85.71%> (+0.26%) 15.00 <4.00> (ø)
...a/org/jboss/pnc/build/finder/report/GAVReport.java 95.65% <100.00%> (ø) 10.00 <1.00> (ø)
.../org/jboss/pnc/build/finder/report/HTMLReport.java 93.92% <100.00%> (ø) 45.00 <1.00> (ø)
...a/org/jboss/pnc/build/finder/report/NVRReport.java 100.00% <100.00%> (ø) 6.00 <1.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ecfbd62...a4fbf71. Read the comment docs.

@dwalluck dwalluck merged commit c0f1eed into project-ncl:master Sep 9, 2020
@dwalluck dwalluck deleted the report-render-text-optional branch September 9, 2020 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant