[NCL-5611] Initial commit to port to protobuf #455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build triggered for merge commit. |
|
Build started for merge commit. |
This commit adds classes to properly serialize class: - MultiValuedMap - LocalFile to Protobuf format. `ProtobufSerializer` is the interface annotated with classes to be considered by the Protobuf Stream processor (Protostream) to generate proto files for serialization and deserialization. The Protobuf format is not yet 'activated' in the codebase as we work on the rest of the classes that need to be serialized via Protobuf. The spotbug-exclude.xml includes the classes generated by Protostream so that they are not scanned for checks
thescouser89
force-pushed
the
ncl-5611-first-protobuf
branch
from
dcd3f55
to
7ee24b5
Compare
|
Build triggered for merge commit. |
|
Build started for merge commit. |
dwalluck
reviewed
Aug 17, 2021
core/src/main/java/org/jboss/pnc/build/finder/protobuf/MultiValuedMapProtobufWrapper.java
Outdated
Show resolved
Hide resolved
dwalluck
reviewed
Aug 17, 2021
core/src/main/java/org/jboss/pnc/build/finder/protobuf/MultiValuedMapProtobufWrapper.java
Outdated
Show resolved
Hide resolved
dwalluck
reviewed
Aug 17, 2021
core/src/main/java/org/jboss/pnc/build/finder/protobuf/MultiValuedMapProtobufWrapper.java
Show resolved
Hide resolved
dwalluck
reviewed
Aug 17, 2021
core/src/main/java/org/jboss/pnc/build/finder/protobuf/ProtobufSerializer.java
Outdated
Show resolved
Hide resolved
dwalluck
reviewed
Aug 17, 2021
core/src/main/java/org/jboss/pnc/build/finder/protobuf/MultiValuedMapProtobufWrapper.java
Outdated
Show resolved
Hide resolved
|
Build triggered for merge commit. |
|
Build started for merge commit. |
dwalluck
reviewed
Aug 17, 2021
core/src/main/java/org/jboss/pnc/build/finder/protobuf/MultiValuedMapProtobufWrapper.java
Show resolved
Hide resolved
dwalluck
reviewed
Aug 17, 2021
core/src/main/java/org/jboss/pnc/build/finder/protobuf/MultiValuedMapProtobufWrapper.java
Outdated
Show resolved
Hide resolved
dwalluck
reviewed
Aug 17, 2021
core/src/main/java/org/jboss/pnc/build/finder/protobuf/MultiValuedMapProtobufWrapper.java
Outdated
Show resolved
Hide resolved
thescouser89
force-pushed
the
ncl-5611-first-protobuf
branch
from
550091e
to
9b2e3a5
Compare
|
Build triggered for merge commit. |
|
Build started for merge commit. |
dwalluck
approved these changes
Aug 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds classes to properly serialize class:
to Protobuf format.
ProtobufSerializeris the interface annotated withclasses to be considered by the Protobuf Stream processor (Protostream)
to generate proto files for serialization and deserialization.
The Protobuf format is not yet 'activated' in the codebase as we work on
the rest of the classes that need to be serialized via Protobuf.
The spotbug-exclude.xml includes the classes generated by Protostream so
that they are not scanned for checks