Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix inconsistent object mapper configuration #458

Merged
merged 1 commit into from
Aug 19, 2021
Merged

Fix inconsistent object mapper configuration #458

merged 1 commit into from
Aug 19, 2021

Conversation

dwalluck
Copy link
Collaborator

No description provided.

@pnc-bot-release
Copy link
Collaborator

Build triggered for merge commit.

@pnc-bot-release
Copy link
Collaborator

Build started for merge commit.

dwalluck
dwalluck commented Aug 19, 2021
View reviewed changes
report/src/test/java/org/jboss/pnc/build/finder/report/ReportTest.java Outdated
Comment on lines 99 to 100
// assertThat(newBuildsString.replace("_", "").toLowerCase(),
// equalToCompressingWhiteSpace(buildsString.replace("_", "").toLowerCase()));
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is failing and it has to be verified that nothing is actually missing.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to be failing before this PR (on #399, too)?

@thescouser89
Copy link
Contributor

thescouser89 commented Aug 19, 2021 •
edited
Loading

This PR fails on my side when running build-finder twice:

  • First time from no cache to generate the data works fine
  • Second time I run it, it loads the data from cache and fails at the very end:
[WARN] Built archive <archive>.jar with 2 unmatched files:[<path>]
java.lang.ClassCastException: class java.util.LinkedHashMap cannot be cast to class java.lang.String (java.util.LinkedHashMap and java.lang.String are in module java.base of loader 'bootstrap')
	at com.redhat.red.build.koji.model.xmlrpc.KojiMavenBuildRequest.lambda$new$2(KojiMavenBuildRequest.java:72)
	at java.base/java.util.stream.Collectors.lambda$uniqKeysMapAccumulator$1(Collectors.java:178)
	at java.base/java.util.stream.ReduceOps$3ReducingSink.accept(ReduceOps.java:169)
	at java.base/java.util.stream.ReferencePipeline$2$1.accept(ReferencePipeline.java:177)
	at java.base/java.util.Iterator.forEachRemaining(Iterator.java:133)
	at java.base/java.util.Spliterators$IteratorSpliterator.forEachRemaining(Spliterators.java:1801)
	at java.base/java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:484)
	at java.base/java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:474)
	at java.base/java.util.stream.ReduceOps$ReduceOp.evaluateSequential(ReduceOps.java:913)
	at java.base/java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234)
	at java.base/java.util.stream.ReferencePipeline.collect(ReferencePipeline.java:578)
	at com.redhat.red.build.koji.model.xmlrpc.KojiMavenBuildRequest.<init>(KojiMavenBuildRequest.java:71)
	at com.redhat.red.build.koji.model.xmlrpc.KojiTaskRequest.asMavenBuildRequest(KojiTaskRequest.java:60)
	at org.jboss.pnc.build.finder.report.HTMLReport.lambda$toHTML$5(HTMLReport.java:330)
	at java.base/java.util.stream.ReferencePipeline$3$1.accept(ReferencePipeline.java:195)
	at java.base/java.util.ArrayList$ArrayListSpliterator.forEachRemaining(ArrayList.java:1655)
	at java.base/java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:484)
	at java.base/java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:474)
	at java.base/java.util.stream.ForEachOps$ForEachOp.evaluateSequential(ForEachOps.java:150)
	at java.base/java.util.stream.ForEachOps$ForEachOp$OfRef.evaluateSequential(ForEachOps.java:173)
	at java.base/java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234)
	at java.base/java.util.stream.ReferencePipeline.forEach(ReferencePipeline.java:497)
	at j2html.tags.ContainerTag.with(ContainerTag.java:106)
	at j2html.TagCreator.each(TagCreator.java:118)
	at org.jboss.pnc.build.finder.report.HTMLReport.toHTML(HTMLReport.java:263)
	at org.jboss.pnc.build.finder.report.HTMLReport.renderText(HTMLReport.java:379)
	at org.jboss.pnc.build.finder.report.Report.outputHTML(Report.java:87)
	at org.jboss.pnc.build.finder.report.Report.generateReports(Report.java:65)
	at org.jboss.pnc.build.finder.cli.Main.call(Main.java:818)
	at org.jboss.pnc.build.finder.cli.Main.call(Main.java:93)
	at picocli.CommandLine.executeUserObject(CommandLine.java:1953)
	at picocli.CommandLine.access$1300(CommandLine.java:145)
	at picocli.CommandLine$RunLast.executeUserObjectOfLastSubcommandWithSameParent(CommandLine.java:2352)
	at picocli.CommandLine$RunLast.handle(CommandLine.java:2346)
	at picocli.CommandLine$RunLast.handle(CommandLine.java:2311)
	at picocli.CommandLine$AbstractParseResultHandler.execute(CommandLine.java:2179)
	at picocli.CommandLine.execute(CommandLine.java:2078)
	at org.jboss.pnc.build.finder.cli.Main.main(Main.java:234)

Let me know if you can reproduce it on your end

@pnc-bot-release
Copy link
Collaborator

Build triggered for merge commit.

@pnc-bot-release
Copy link
Collaborator

Build started for merge commit.

@thescouser89
Copy link
Contributor

With the current PR changes, I can confirm running build-finder twice works now. Thanks @dwalluck !

@thescouser89 thescouser89 self-requested a review August 19, 2021 19:15
@pnc-bot-release
Copy link
Collaborator

Build triggered for merge commit.

@pnc-bot-release
Copy link
Collaborator

Build started for merge commit.

@pnc-bot-release
Copy link
Collaborator

Build triggered for merge commit.

@pnc-bot-release
Copy link
Collaborator

Build started for merge commit.

@pnc-bot-release
Copy link
Collaborator

Build triggered for merge commit.

@pnc-bot-release
Copy link
Collaborator

Build started for merge commit.

@pnc-bot-release
Copy link
Collaborator

Build triggered for merge commit.

@pnc-bot-release
Copy link
Collaborator

Build started for merge commit.

@dwalluck dwalluck merged commit 47d95ff into project-ncl:master Aug 19, 2021
@dwalluck dwalluck deleted the object-mapper branch August 19, 2021 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thescouser89 thescouser89 thescouser89 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dwalluck @pnc-bot-release @thescouser89