[NCL-6344] Implement Supplier interface #603
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implement Supplier interface for `BuildFinder` and `DistributionAnalyzer`. This is useful when invoking both of them in a `CompletableFuture.supplyAsync` to produce a `CompletableFuture`. The latter can then be composed and combined with other `CompletableFuture`s. One reason for using that composability for NCL-6344 is to implement a cancellation feature. The flow goes from: url -> DistributionAnalyzer -> BuildFinder When running `DistributionAnalyzer` and `BuildFinder` as a future, it is really impossible to stop them in case of cancellation. However, we can cancel the rest of the flow after them. url -> future(DistributionAnalyzer) -> check if cancelled -> future(BuildFinder) Using a `CompletableFuture` makes this much easier.
|
Build triggered for merge commit. |
|
Build started for merge commit. |
dwalluck
approved these changes
Mar 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement Supplier interface for
BuildFinderandDistributionAnalyzer. This is useful when invoking both of them in aCompletableFuture.supplyAsyncto produce aCompletableFuture. Thelatter can then be composed and combined with other
CompletableFutures.One reason for using that composability for NCL-6344 is to implement a
cancellation feature. The flow goes from:
url -> DistributionAnalyzer -> BuildFinder
When running
DistributionAnalyzerandBuildFinderas a future, it isreally impossible to stop them in case of cancellation. However, we can
cancel the rest of the flow after them.
url -> future(DistributionAnalyzer) -> check if cancelled -> future(BuildFinder)
Using a
CompletableFuturemakes this much easier.