Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make runner show a summary of failed steps at the end of the execution #1234

Closed
tiziano88 opened this issue Jul 3, 2020 · 2 comments · Fixed by #1286
Closed

Make runner show a summary of failed steps at the end of the execution #1234

tiziano88 opened this issue Jul 3, 2020 · 2 comments · Fixed by #1286
Assignees

Comments

@tiziano88
Copy link
Collaborator

I think it is great that this command runs all the steps even if something fails in between.
I suggest logging a summary of the failures or the list of failed steps in the end, so that one does not have to go through the entire log to locate the problem.

Originally posted by @rbehjati in #1190

@ipetr0v
Copy link
Contributor

ipetr0v commented Jul 23, 2020

Should it only apply to run_ci?
If so, we need to also add a name for each Step, and only show top-level steps (like run_examples_rust or run_tests) and don't show low level steps (like build_wasm_modules).

@ipetr0v
Copy link
Contributor

ipetr0v commented Jul 24, 2020

Adding a PR #1286.
Error summary in the end will look like an exact list of failed steps:

Finished with errors:
 ❯ examples ❯ hello_world ❯ build application ⊢ [ERROR]

@ipetr0v ipetr0v self-assigned this Jul 24, 2020
ipetr0v added a commit that referenced this issue Jul 27, 2020
This change adds a short failure summary in `runner`.

Fixes #1234
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants