-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pass TLS credentials to gRPC server pseudo-node without modifying the ApplicationConfiguration #961
Comments
No, I haven't yet. |
Happy to take a look myself as part of #917, thanks! |
tiziano88
added a commit
to tiziano88/oak
that referenced
this issue
May 21, 2020
tiziano88
added a commit
to tiziano88/oak
that referenced
this issue
May 21, 2020
tiziano88
added a commit
to tiziano88/oak
that referenced
this issue
May 21, 2020
3 tasks
tiziano88
added a commit
to tiziano88/oak
that referenced
this issue
May 21, 2020
tiziano88
added a commit
to tiziano88/oak
that referenced
this issue
May 21, 2020
tiziano88
added a commit
to tiziano88/oak
that referenced
this issue
May 21, 2020
tiziano88
added a commit
that referenced
this issue
May 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
oak/oak/server/rust/oak_loader/src/main.rs
Lines 88 to 96 in ca7f1ee
Apart from not being very idiomatic (why does oak_loader modify the ApplicationConfiguration object that was supposed to run?), it is problematic for #917 and other related refactorings.
I guess the final solution may be dependant on #689 , but in the meanwhile we can just pass the TLS credentials directly to the Runtime object, and have that propagate them to the gRPC pseudo-node at creation time.
The text was updated successfully, but these errors were encountered: