Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run tests in CI with
runner
#1190Run tests in CI with
runner
#1190Changes from 31 commits
6f41e9b
37df7a1
40064ca
54b5d27
038d146
ed4f824
606f059
0be2c78
dc5c41d
94a1c97
e46f1dd
dc4109c
3e5ead1
d3264e4
180b824
c6871f1
81b8822
574cb65
f09847a
bb2f2ec
20c8a46
8985433
3d9e950
96b8af8
f74c9bd
d398940
e2e2b28
cfd6e6b
7783ec2
54d0e0a
4e8b55b
32af173
538887d
798b94e
88a413b
a0ea3fb
928617d
85f1906
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does
thisrunner
include thehello_world
C++ module? I couldn't immediately see it in the Cloudbuild output.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was commented out, added it back now, but it's only built, not run. I think if we want to run it we should probably do what you suggested and split it into a separate app anyways.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Glad we changed the naming, makes things clearer :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pre-existing nit below:
[clients] cpp
is not accurate, it would be nice to sync this with #1170.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is accurate, i.e. it is the
cpp
client, and it is built viabazel
, which is what the details of the entry says.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, my bad, this isn't a fixed schema – this comment belongs elsewhere…