Add push_example script #1229
Add push_example script #1229
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1229 +/- ##
==========================================
+ Coverage 31.56% 31.73% +0.17%
==========================================
Files 53 53
Lines 6787 6793 +6
Branches 3195 3198 +3
==========================================
+ Hits 2142 2156 +14
+ Misses 2703 2680 -23
- Partials 1942 1957 +15
Continue to review full report at Codecov.
|
| while getopts "e:h" opt; do | ||
| case "${opt}" in | ||
| h) | ||
| echo -e "Usage: ${0} [-h] -e EXAMPLE | ||
|
|
||
| Save example modules in Google Cloud Storage. | ||
|
|
||
| Options: | ||
| -e Example application name (required) | ||
| -h Print Help (this message) and exit" | ||
| exit 0;; | ||
| e) | ||
| readonly EXAMPLE="${OPTARG}";; | ||
| *) | ||
| echo "Invalid argument: ${OPTARG}" | ||
| exit 1;; | ||
| esac | ||
| done |
There was a problem hiding this comment.
This seems excessive :) The error message below should be enough I think?
There was a problem hiding this comment.
Just making it similar to other scripts that use -e for referring to an example.
There was a problem hiding this comment.
I still suggest we use -e for the example.. but seeing that this has only one way to use it, I don't think we need all the getops code for it. If you remove this and it's not used correctly, it will still print the correct message
There was a problem hiding this comment.
I have only one word to add, and I am not even going to actually mention it :) (it starts with R)
There was a problem hiding this comment.
I can just make it so that ${1} will be -e and ${2} will be a parameter.
But I think it will be less readable.
There was a problem hiding this comment.
let's keep as it is for now, and think what to do about it in runner perhaps in the future.
ipetr0v
force-pushed
the
gcp_push_examples
branch
from
3f3f033
to
fc1201b
Compare
|
The only problem with this script, is that in order to build reproducibly, we need to build examples in Docker. |
| while getopts "e:h" opt; do | ||
| case "${opt}" in | ||
| h) | ||
| echo -e "Usage: ${0} [-h] -e EXAMPLE | ||
|
|
||
| Save example modules in Google Cloud Storage. | ||
|
|
||
| Options: | ||
| -e Example application name (required) | ||
| -h Print Help (this message) and exit" | ||
| exit 0;; | ||
| e) | ||
| readonly EXAMPLE="${OPTARG}";; | ||
| *) | ||
| echo "Invalid argument: ${OPTARG}" | ||
| exit 1;; | ||
| esac | ||
| done |
There was a problem hiding this comment.
let's keep as it is for now, and think what to do about it in runner perhaps in the future.
|
Reproducibility Index: Reproducibility Index diff: diff --git a/reproducibility_index b/reproducibility_index
index 297a0b3..e81a0b4 100644
--- a/reproducibility_index
+++ b/reproducibility_index
@@ -10,4 +10,4 @@ df1a5f037bce9ca20b556f50c7cd1bf1780cbf0d378609462f18f5d5b8589ffb ./examples/tar
6b450333f5d36c454a186af9add9f29f9326162cb4b5516b41ff9f29cd9b87e0 ./examples/target/wasm32-unknown-unknown/release/running_average.wasm
849708ee562d66ec7c0a8b0f65d509bae4c1e4c7381e72b4b1ae9091be7e3454 ./examples/target/wasm32-unknown-unknown/release/translator.wasm
cd393c0c7a97265fdb8ca514cdfcee7d8379d84c1019262a71267c2c7df12491 ./examples/target/wasm32-unknown-unknown/release/trusted_information_retrieval.wasm
-f7e04fec862016c4c4dfdb816062cd5227cf8325b3340e5cdbf7d29ff7d5a714 ./oak/server/target/x86_64-unknown-linux-musl/release/oak_loader
+7f1e1ecff2ab9845dbbe8cf93ede831ec7b5d4e0efebe6718e0c9017ec254a3e ./oak/server/target/x86_64-unknown-linux-musl/release/oak_loader
|
This change adds a script for saving example modules in Google Storage.
Ref #1183
Checklist
construction.