Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bin directory for oak_loader #1230

Merged
merged 3 commits into from
Jul 6, 2020
Merged

Conversation

ipetr0v
Copy link
Contributor

@ipetr0v ipetr0v commented Jul 3, 2020

This change adds a binary directory for oak_loader.

Fixes #719
Originated from #1214 (comment)

Checklist

  • Pull request includes prototype/experimental work that is under
    construction.

@ipetr0v
Copy link
Contributor Author

ipetr0v commented Jul 3, 2020

If we will compile oak_loader in bin, do we need to run it from there?
Or we should still use cargo run ...?
cc @anghelcovici @tiziano88

@tiziano88
Copy link
Collaborator

If we will compile oak_loader in bin, do we need to run it from there?
Or we should still use cargo run ...?
cc @anghelcovici @tiziano88

I feel we should stop using cargo run and bazel run at some point, it's not very realistic of how the binaries are normally run. So I vote for building first, and then running as binary later. Happy to hear other opinions though.

@ipetr0v ipetr0v marked this pull request as ready for review July 6, 2020 13:56
@ipetr0v ipetr0v requested a review from tiziano88 July 6, 2020 13:56
.gitignore Outdated Show resolved Hide resolved
@ipetr0v ipetr0v merged commit 8bc660c into project-oak:main Jul 6, 2020
@ipetr0v ipetr0v deleted the server_bin_dir branch July 6, 2020 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Directory for compilation artifacts
3 participants