-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove the UEFI app #2956
Merged
Merged
Remove the UEFI app #2956
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jul-sh
requested review from
rbehjati,
andrisaar,
tiziano88,
conradgrobler and
a team
and removed request for
a team and
rbehjati
June 13, 2022 16:06
conradgrobler
approved these changes
Jun 13, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. I assume renaming experimental/uefi to experimental/baremetal will be done in a follow-up PR, is that the case?
tiziano88
approved these changes
Jun 13, 2022
andrisaar
approved these changes
Jun 13, 2022
@conradgrobler Indeed. Doing this separately as it'll make potential reverts easier |
Reproducibility Index:
Reproducibility Index diff: |
jul-sh
added a commit
to jul-sh/oak
that referenced
this pull request
Jun 13, 2022
jul-sh
added a commit
to jul-sh/oak
that referenced
this pull request
Jun 13, 2022
jul-sh
added a commit
to jul-sh/oak
that referenced
this pull request
Jun 13, 2022
jul-sh
added a commit
to jul-sh/oak
that referenced
this pull request
Jun 13, 2022
jul-sh
added a commit
to jul-sh/oak
that referenced
this pull request
Jun 13, 2022
jul-sh
added a commit
to jul-sh/oak
that referenced
this pull request
Jun 13, 2022
jul-sh
added a commit
that referenced
this pull request
Jun 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will clean up the folder structure in a separate PR. If we ever want to revert deleting this code in the future it'll be easier if recorded as a distinct merge commit.