Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the UEFI app #2956

Merged
merged 1 commit into from
Jun 13, 2022
Merged

Remove the UEFI app #2956

merged 1 commit into from
Jun 13, 2022

Conversation

jul-sh
Copy link
Contributor

@jul-sh jul-sh commented Jun 13, 2022

Will clean up the folder structure in a separate PR. If we ever want to revert deleting this code in the future it'll be easier if recorded as a distinct merge commit.

@jul-sh jul-sh marked this pull request as ready for review June 13, 2022 16:06
@jul-sh jul-sh requested a review from a team as a code owner June 13, 2022 16:06
@jul-sh jul-sh requested review from rbehjati, andrisaar, tiziano88, conradgrobler and a team and removed request for a team and rbehjati June 13, 2022 16:06
Copy link
Collaborator

@conradgrobler conradgrobler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I assume renaming experimental/uefi to experimental/baremetal will be done in a follow-up PR, is that the case?

@jul-sh jul-sh merged commit c0c5be4 into project-oak:main Jun 13, 2022
@jul-sh
Copy link
Contributor Author

jul-sh commented Jun 13, 2022

@conradgrobler Indeed. Doing this separately as it'll make potential reverts easier

@github-actions
Copy link

Reproducibility Index:

51e5574ee17f414687f39bf354f4be3d1a9b3ed352fb21f3da5c8ce32b978fbf  ./target/x86_64-unknown-linux-musl/release/oak_functions_loader_base
3b92b8ed8b4cfc712e29ddfd8e1993173eda00f2837fae77e1e369e9ccb06c99  ./target/x86_64-unknown-linux-musl/release/oak_functions_loader_unsafe

Reproducibility Index diff:

jul-sh added a commit to jul-sh/oak that referenced this pull request Jun 13, 2022
jul-sh added a commit to jul-sh/oak that referenced this pull request Jun 13, 2022
jul-sh added a commit to jul-sh/oak that referenced this pull request Jun 13, 2022
jul-sh added a commit to jul-sh/oak that referenced this pull request Jun 13, 2022
jul-sh added a commit to jul-sh/oak that referenced this pull request Jun 13, 2022
jul-sh added a commit to jul-sh/oak that referenced this pull request Jun 13, 2022
jul-sh added a commit that referenced this pull request Jun 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants