Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add application config serializer #459

Merged
merged 9 commits into from
Jan 14, 2020
Merged

Add application config serializer #459

merged 9 commits into from
Jan 14, 2020

Conversation

ipetr0v
Copy link
Contributor

@ipetr0v ipetr0v commented Jan 10, 2020 •
edited
Loading

This change adds an Oak application configuration serializer

Fixes #412

@ipetr0v ipetr0v added the WIP Work in progress label Jan 10, 2020
@ipetr0v ipetr0v marked this pull request as ready for review January 10, 2020 18:51
@ipetr0v ipetr0v removed the WIP Work in progress label Jan 10, 2020
tiziano88
tiziano88 reviewed Jan 10, 2020
View reviewed changes
Copy link
Collaborator

@tiziano88 tiziano88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Ivan, adding @daviddrysdale to take a look too.

oak/common/app_config.h Outdated Show resolved Hide resolved
oak/common/utils.cc Outdated Show resolved Hide resolved
oak/common/app_config_serializer.cc Show resolved Hide resolved
daviddrysdale
daviddrysdale reviewed Jan 13, 2020
View reviewed changes
oak/common/utils.h Outdated Show resolved Hide resolved
oak/common/app_config.cc Outdated Show resolved Hide resolved
oak/common/app_config_serializer.cc Outdated Show resolved Hide resolved
oak/common/app_config_serializer.cc Outdated Show resolved Hide resolved
oak/common/app_config_serializer.cc Outdated Show resolved Hide resolved
oak/common/app_config_serializer.cc Show resolved Hide resolved
oak/common/app_config_serializer.cc Show resolved Hide resolved
oak/common/app_config_serializer.cc Outdated Show resolved Hide resolved
oak/common/app_config_serializer.cc Show resolved Hide resolved
@ipetr0v ipetr0v merged commit c4870b5 into project-oak:master Jan 14, 2020
@ipetr0v ipetr0v deleted the packed_app_config branch January 14, 2020 12:11
@ipetr0v ipetr0v mentioned this pull request Mar 20, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tiziano88 tiziano88 tiziano88 approved these changes

@daviddrysdale daviddrysdale Awaiting requested review from daviddrysdale

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pack app configuration in a Proto file
4 participants
@ipetr0v @tiziano88 @daviddrysdale @googlebot