Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tonic as a crate in cargo-raze #891

Merged
merged 5 commits into from
Apr 27, 2020
Merged

Add tonic as a crate in cargo-raze #891

merged 5 commits into from
Apr 27, 2020

Conversation

ipetr0v
Copy link
Contributor

@ipetr0v ipetr0v commented Apr 22, 2020 •
edited
Loading

This change:

  • Adds tonic as a dependency using cargo-raze
  • Updates bazel_rules_rust

Fixes #890

Checklist

  • Pull request includes prototype/experimental work that is under
    construction.

@ipetr0v ipetr0v mentioned this pull request Apr 22, 2020
Merged
1 task
@ipetr0v ipetr0v marked this pull request as ready for review April 23, 2020 14:44
@ipetr0v ipetr0v force-pushed the raze_tonic branch 2 times, most recently from 04cb191 to 23d4084 Compare April 23, 2020 14:53
@tiziano88 tiziano88 removed their request for review April 23, 2020 15:29
@tiziano88
Copy link
Collaborator

I don't have much to contribute, I'll let @daviddrysdale approve

@ipetr0v ipetr0v mentioned this pull request Apr 23, 2020
Closed
15 tasks
daviddrysdale
daviddrysdale approved these changes Apr 26, 2020
View reviewed changes
cargo/Cargo.toml
@@ -25,6 +26,9 @@ prost-types = "*"
rand = "*"
simple_logger = "*"
tokio = { version = "*", features = ["rt-core"] }
# Using an old version that is supported by `cargo-raze`:
# https://github.com/google/cargo-raze/issues/41#issuecomment-592274128
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for putting these comments in – they'll be useful breadcrumbs to help whoever next has to fight cargo raze.

@ipetr0v ipetr0v merged commit b20175f into project-oak:master Apr 27, 2020
@ipetr0v ipetr0v deleted the raze_tonic branch April 27, 2020 09:32
@github-actions
Copy link

Reproducibility index:

b872c022d6cd4aeec687d276fbff8d0a66a12e99f0b45a563f1284244dd09510  ./target/wasm32-unknown-unknown/release/abitest_0_frontend.wasm
9869e2191b330526dbd4426badc3d1f81e41daba5f2975e5cdcf6e2365f10b8c  ./target/wasm32-unknown-unknown/release/abitest_1_backend.wasm
5e74de1492f2c2b7c95518c8d064f0f02b8cc56d248d1b39ff56535fc91e790a  ./target/wasm32-unknown-unknown/release/aggregator.wasm
5ce16b592e32565edcbd9e3b9f37bd5e7a8914238b04762af2ef93926e884dd2  ./target/wasm32-unknown-unknown/release/chat.wasm
4cbdc184d6cd6892c5cb505bf8ec84b264d4ef5472b7df481d02dae5dec40fe8  ./target/wasm32-unknown-unknown/release/hello_world.wasm
3fc642ca976775d25822b83786cd5836ae24ee0b0ee9145891e3925cc8147e4c  ./target/wasm32-unknown-unknown/release/machine_learning.wasm
fc740916548457c617f9074e62e62879b62cb7a762fc9d36bf098da3c26259b9  ./target/wasm32-unknown-unknown/release/private_set_intersection.wasm
941f7bec35707e059c7dd48be26a171583268b629aa0d83cf51c155d23bba67c  ./target/wasm32-unknown-unknown/release/running_average.wasm
c09e11c45426a690e2b0803db48361ba2392ee006fae1de903b772d00efd6b36  ./target/wasm32-unknown-unknown/release/translator.wasm
7802c19f981cb105185af8022bcee2612cf99c20ea446a55065a92177d9d5087  ./target/x86_64-unknown-linux-musl/release/oak_loader

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daviddrysdale daviddrysdale daviddrysdale approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add tonic as a crate in cargo-raze
4 participants
@ipetr0v @tiziano88 @daviddrysdale @googlebot