Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redirect ABI method comments to documentation #979

Merged
merged 1 commit into from
May 12, 2020
Merged

Redirect ABI method comments to documentation #979

merged 1 commit into from
May 12, 2020

Conversation

tiziano88
Copy link
Collaborator

I was tired of trying to keep the parameter numbers in sync :)

Fix ABI documentation to not repeat types, and use terminology more in
line with standard WebAssembly (see
https://hacks.mozilla.org/2019/11/multi-value-all-the-wasm/ for the
choice of param and result in particular).

Ref #877

Checklist

  • Pull request affects core Oak functionality (e.g. runtime, SDK, ABI)
    • I have written tests that cover the code changes.
    • I have checked that these tests are run by Cloudbuild
    • I have updated documentation accordingly.
    • I have raised an issue to
      cover any TODOs and/or unfinished work.
  • Pull request includes prototype/experimental work that is under
    construction.

@tiziano88
Redirect ABI method comments to documentation
949e840 
I was tired of trying to keep the parameter numbers in sync :)

Fix ABI documentation to not repeat types, and use terminology more in
line with standard WebAssembly (see
https://hacks.mozilla.org/2019/11/multi-value-all-the-wasm/ for the
choice of `param` and `result` in particular).

Ref project-oak#877
@tiziano88 tiziano88 merged commit 11f96d6 into project-oak:master May 12, 2020
@tiziano88 tiziano88 deleted the tzn_abi_docs branch May 12, 2020 18:46
@github-actions
Copy link

Reproducibility index:

172d711e5a55af5344316474a5ddac752df3f0a37119da92021d32bb89a7003e  ./target/wasm32-unknown-unknown/release/abitest_0_frontend.wasm
6b237a388a32f724f4e6d8a5b0468f641d8cb2506fc578dc7c77b496ff62369e  ./target/wasm32-unknown-unknown/release/abitest_1_backend.wasm
8751bebd9fe5b6ad73a168a067e73a0e3d6a2de73e3e7f9d334895a1ccd59fec  ./target/wasm32-unknown-unknown/release/aggregator.wasm
eda11289a9e128ba20b4920aa2ed8b17d12d707464d56ea2aaae73c7343f25e3  ./target/wasm32-unknown-unknown/release/chat.wasm
1995ff75e523dda9165a1e3749011d05d293c8d8ca05c9f6075d6321471c4ced  ./target/wasm32-unknown-unknown/release/hello_world.wasm
296d669f7d657ade8e8db4a3f2545b4875194babb3b5f88610ee298a4ba8cd62  ./target/wasm32-unknown-unknown/release/machine_learning.wasm
4e71f536b6ea366c1595a96e0c6f3eacd86855cdd2a9c4ea7239843a5af14d1a  ./target/wasm32-unknown-unknown/release/private_set_intersection.wasm
c41676f7c5336807c1fea5616b0eae4705c716abc9e0b056443df671565bbf2b  ./target/wasm32-unknown-unknown/release/running_average.wasm
91f12039c5f7141690ede22a3ae1c6f90dc665e4c6ec867f41238429e9428875  ./target/wasm32-unknown-unknown/release/translator.wasm

@daviddrysdale
Copy link
Contributor

BTW, does this resolve #877 and #812 ?

@daviddrysdale daviddrysdale mentioned this pull request May 28, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daviddrysdale daviddrysdale daviddrysdale approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tiziano88 @daviddrysdale @googlebot