Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect command in docs #2991

Merged
merged 2 commits into from
Jun 21, 2022
Merged

Fix incorrect command in docs #2991

merged 2 commits into from
Jun 21, 2022

Conversation

jul-sh
Copy link
Contributor

@jul-sh jul-sh commented Jun 21, 2022

Made a typo here when creating this file in #2956.

@jul-sh jul-sh marked this pull request as ready for review June 21, 2022 11:53
@jul-sh jul-sh requested a review from a team as a code owner June 21, 2022 11:53
@jul-sh jul-sh requested review from ipetr0v and removed request for a team June 21, 2022 11:53
@@ -8,7 +8,7 @@ endpoint exposed by the untrusted companion app.
Running the client may be started vua
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pre-existing: "vua" -> "via"

@@ -8,7 +8,7 @@ endpoint exposed by the untrusted companion app.
Running the client may be started vua

```shell
cargo run experimental/oak_baremetal_client
cargo run --package oak_baremetal_client
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: for consistency I think --package=oak_baremetal_client would be preferred.

@jul-sh jul-sh merged commit a442592 into project-oak:main Jun 21, 2022
@jul-sh jul-sh deleted the docs branch June 21, 2022 18:06
@github-actions
Copy link

Reproducibility Index:

a255d6b260693269e3152318d32e58f6dad869875b98bf0b0ca21183ba97f71b  ./target/x86_64-unknown-linux-musl/release/oak_functions_loader_base
7cb27c719939784bc77309de8136d765539abdb205493b45d71e7a07e27dd0ee  ./target/x86_64-unknown-linux-musl/release/oak_functions_loader_unsafe

Reproducibility Index diff:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants