Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #282 use requiredby to make a hard dependency chain #283

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Klaas-
Copy link

@Klaas- Klaas- commented Jun 28, 2019

Fixes #282 use requiredby to make a hard dependency chain

@rh-atomic-bot
Copy link

Can one of the admins verify this patch?
I understand the following commands:

  • bot, add author to whitelist
  • bot, test pull request
  • bot, test pull request once

@rhatdan
Copy link
Member

rhatdan commented Jun 28, 2019

@rhvgoyal PTAL
As I recall we wanted to allow this to fail in order to allow Docker running with Devicemapper on loopback devices to work. I think containers-storage-setup would fail in that situation and cause Docker to use loopback devices. Now that we default to using Overlay, we could perhaps make the switch.

@Klaas-
Copy link
Author

Klaas- commented Jun 28, 2019

So there is a situation where you expect the service to fail? Wouldn't it be better/easier to just not use the service ie when dm on loopback "systemctl disable docker-storage-setup"? or even fully remove the package and only install it when needed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failed mount does not lead to startup error
3 participants