Avoid deleting all endpoints when a watch fails #6979
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marvin-tigera
added
docs-pr-required
|
|
jingqgeng
force-pushed
the
check-ep-id-exists
branch
from
0c2778e
to
7f21770
Compare
jingqgeng
force-pushed
the
check-ep-id-exists
branch
from
7f21770
to
571333c
Compare
|
@neiljerram would you be able to do a quick review of this one? |
|
/sem-approve |
mgleung
approved these changes
Jan 6, 2023
mgleung
added
docs-not-required
marvin-tigera
removed
release-note-required
nelljerram
added a commit
to nelljerram/calico
that referenced
this pull request
Jan 17, 2023
We had a bug in product code that was recently fixed by projectcalico#6979. That bug caused some port statuses to be signalled as "None" when they should not be. Unfortunately we also had this test (test_snapshot) that had been coded to match the bug, i.e. to expect a port status update of "None". The correct behaviour is that the port status should not be changed by this passage of test code. This was missed at the time of the 6979 PR because our UT running had a bug that allowed some tests to fail but still reported success overall.
nelljerram
added a commit
to nelljerram/calico
that referenced
this pull request
Sep 19, 2023
We had a bug in product code that was recently fixed by projectcalico#6979. That bug caused some port statuses to be signalled as "None" when they should not be. Unfortunately we also had this test (test_snapshot) that had been coded to match the bug, i.e. to expect a port status update of "None". The correct behaviour is that the port status should not be changed by this passage of test code. This was missed at the time of the 6979 PR because our UT running had a bug that allowed some tests to fail but still reported success overall.
odilo
pushed a commit
to odilo/networking-calico
that referenced
this pull request
Jul 9, 2024
We had a bug in product code that was recently fixed by projectcalico/calico#6979. That bug caused some port statuses to be signalled as "None" when they should not be. Unfortunately we also had this test (test_snapshot) that had been coded to match the bug, i.e. to expect a port status update of "None". The correct behaviour is that the port status should not be changed by this passage of test code. This was missed at the time of the 6979 PR because our UT running had a bug that allowed some tests to fail but still reported success overall.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, whenever a watch fails, a new snapshot is loaded and we want to check if the endpoint ids in the old snapshot still exist in the new snapshot. But instead of looking up each endpoint id, this line of code looks up the set of endpoint ids, which will never work. Hence this bug fix.
Related issues/PRs
Todos
Release Note
Reminder for the reviewer
Make sure that this PR has the correct labels and milestone set.
Every PR needs one
docs-*label.docs-pr-required: This change requires a change to the documentation that has not been completed yet.docs-completed: This change has all necessary documentation completed.docs-not-required: This change has no user-facing impact and requires no docs.Every PR needs one
release-note-*label.release-note-required: This PR has user-facing changes. Most PRs should have this label.release-note-not-required: This PR has no user-facing changes.Other optional labels:
cherry-pick-candidate: This PR should be cherry-picked to an earlier release. For bug fixes only.needs-operator-pr: This PR is related to install and requires a corresponding change to the operator.