-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Skip setting node IP annotation if CALICO_NETWORKING_BACKEND=none #7550
Conversation
/sem-approve |
@skmatti it appears that a formatting check didn't pass on our end. Could I get you to run |
`projectcalico.org/IPv4Address` and `projectcalico.org/IPv4IPIPTunnelAddr` annotations are used for BGP so disabling these in `policy` only mode
@mgleung Thanks for review. I have updated the PR with formatting fixed. |
/sem-approve |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sorry for the delay @skmatti and thanks for the contribution! |
`projectcalico.org/IPv4Address` and `projectcalico.org/IPv4IPIPTunnelAddr` annotations are used for BGP so disabling these in `policy` only mode Cherrypicks projectcalico#7550 Change-Id: I4afc43f5c2306a2bd93ecb45876cdb5854aedb50
Followup to projectcalico#7550 Bug: 237698160 Change-Id: I185a179df725d4f113abe966c4dfc5f27fd521d8
Followup to projectcalico#7550 Change-Id: Icb738cf2d2f84c175812ac12b31c95f63139fe31
Followup to projectcalico#7550 Change-Id: I01c8018c9d47401383f05861865ff0c9b44c506e
Followup to projectcalico#7550 Change-Id: I01c8018c9d47401383f05861865ff0c9b44c506e
Followup to projectcalico#7550 Change-Id: I01c8018c9d47401383f05861865ff0c9b44c506e
Description
projectcalico.org/IPv4Address
andprojectcalico.org/IPv4IPIPTunnelAddr
annotations are used for BGP so disabling these inpolicy
only modeIf we remove this dependency, calico-node in policy only mode does not need k8s node update/ patch permissions which addresses a vulnerability associated with node agent's over provisioned permissions.
Release Note
Reminder for the reviewer
Make sure that this PR has the correct labels and milestone set.
Every PR needs one
docs-*
label.docs-pr-required
: This change requires a change to the documentation that has not been completed yet.docs-completed
: This change has all necessary documentation completed.docs-not-required
: This change has no user-facing impact and requires no docs.Every PR needs one
release-note-*
label.release-note-required
: This PR has user-facing changes. Most PRs should have this label.release-note-not-required
: This PR has no user-facing changes.Other optional labels:
cherry-pick-candidate
: This PR should be cherry-picked to an earlier release. For bug fixes only.needs-operator-pr
: This PR is related to install and requires a corresponding change to the operator.