-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BPF Dump policies without assembly replaced with more condensed rule counters output #7954
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the --verbose flag! 👍 see my comment on the output.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just a second thought nit ... i wonder whether --verbose would not collide with a possible global --verbose flag and whether something like --asm | Includes eBPF assembler code of the policy program
would be better. Or perhaps --code
🤔
Thanks @tomastigera - actually I did think about However, I like this suggestion to use something else - I think |
Update |
…le counters output
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Currently the Calico BPF utility policy dump is very verbose and includes assembly which is not relevant to most users i.e. output from the command:
kubectl exec calico-node-xyz -n calico-system -- calico-node -bpf policy dump cali2c5f0ef34cf ingress
Therefore, this simple requirement is to omit the irrelevant assembly and instead present more condense output including the rule counters only e.g.
However, there is an option to append either
-a
or--asm
to the command above to include the original verbose output as before i.e.kubectl exec calico-node-xyz -n calico-system -- calico-node -bpf policy dump cali2c5f0ef34cf ingress -a
OR
kubectl exec calico-node-xyz -n calico-system -- calico-node -bpf policy dump cali2c5f0ef34cf ingress --asm
Description
Related issues/PRs
Todos
Release Note
Reminder for the reviewer
Make sure that this PR has the correct labels and milestone set.
Every PR needs one
docs-*
label.docs-pr-required
: This change requires a change to the documentation that has not been completed yet.docs-completed
: This change has all necessary documentation completed.docs-not-required
: This change has no user-facing impact and requires no docs.Every PR needs one
release-note-*
label.release-note-required
: This PR has user-facing changes. Most PRs should have this label.release-note-not-required
: This PR has no user-facing changes.Other optional labels:
cherry-pick-candidate
: This PR should be cherry-picked to an earlier release. For bug fixes only.needs-operator-pr
: This PR is related to install and requires a corresponding change to the operator.