BPF Dump policies without assembly replaced with more condensed rule counters output

[ghost]

Currently the Calico BPF utility policy dump is very verbose and includes assembly which is not relevant to most users i.e. output from the command:
kubectl exec calico-node-xyz -n calico-system -- calico-node -bpf policy dump cali2c5f0ef34cf ingress

Therefore, this simple requirement is to omit the irrelevant assembly and instead present more condense output including the rule counters only e.g.

IfaceName: cali2c5f0ef34cf
Hook: tc egress
Error: 
Policy Info:
// Start of policy default.policy-tcp
// Start of rule action:"allow" protocol:<name:"tcp" > src_net:"11.0.0.8/32" src_net:"10.0.0.8/32" src_ports:<first:8055 last:8055 > src_ports:<first:100 last:105 > dst_net:"12.0.0.8/32" dst_net:"13.0.0.8/32" dst_ports:<first:9055 last:9055 > dst_ports:<first:200 last:205 > rule_id:"STaSnQYmIymqngjx" 
// count = 0

However, there is an option to append either -a or --asm to the command above to include the original verbose output as before i.e.
kubectl exec calico-node-xyz -n calico-system -- calico-node -bpf policy dump cali2c5f0ef34cf ingress -a
OR
kubectl exec calico-node-xyz -n calico-system -- calico-node -bpf policy dump cali2c5f0ef34cf ingress --asm

Description

Related issues/PRs

Todos

• Tests
• Documentation
• Release note

Release Note

calico-node -bpf dump policy now suppresses printing assembly by default. You need to use --asm flag [or -a] to see the assembly as well.

Reminder for the reviewer

Make sure that this PR has the correct labels and milestone set.

Every PR needs one docs-* label.

• docs-pr-required: This change requires a change to the documentation that has not been completed yet.
• docs-completed: This change has all necessary documentation completed.
• docs-not-required: This change has no user-facing impact and requires no docs.

Every PR needs one release-note-* label.

• release-note-required: This PR has user-facing changes. Most PRs should have this label.
• release-note-not-required: This PR has no user-facing changes.

Other optional labels:

• cherry-pick-candidate: This PR should be cherry-picked to an earlier release. For bug fixes only.
• needs-operator-pr: This PR is related to install and requires a corresponding change to the operator.

[tomastigera]

I like the --verbose flag! 👍 see my comment on the output.

[tomastigera]

LGTM, just a second thought nit ... i wonder whether --verbose would not collide with a possible global --verbose flag and whether something like --asm | Includes eBPF assembler code of the policy program would be better. Or perhaps --code 🤔

[ghost]

LGTM, just a second thought nit ... i wonder whether --verbose would not collide with a possible global --verbose flag and whether something like --asm | Includes eBPF assembler code of the policy program would be better. Or perhaps --code 🤔

Thanks @tomastigera - actually I did think about -v shorthand flag for verbose here may collide with global -v for version but I see that this was OK because for verbose as one would add the -v flag after the policy dump command i.e. like this
policy dump cali2c5f0ef34cf ingress -v so all seemed fine - I wasn't aware of the --verbose global flag though

However, I like this suggestion to use something else - I think --asm is the best option because it is the most specific option for this particular command policy dump so I would like to change to --asm accordingly - thanks for the suggestion / recommendation!

[ghost]

Update --verbose flag to --asm flag as discussed above

[tomastigera]

Thanks!