-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Typha Deployment tolerations to helm charts so that it can be scheduled on any node #7979
Update Typha Deployment tolerations to helm charts so that it can be scheduled on any node #7979
Conversation
Allow typha deployment to tolerate the taint set via kubelet when used with --cloud-provider=external flag. We need typha to be able to schedule as soon as possible on new nodes since calico-node relies on it. Related Slack thread: https://calicousers.slack.com/archives/C0BCA117T/p1693469918340899
I think Typha and calico-node should have the exact same Tolerations since calico-node requires Typha to be up to come up itself. Can a core-maintainer confirm that position please? |
Co-authored-by: Lance Robson <[email protected]>
* Allow calico-typha Deployment to be scheduled on all nodes projectcalico/calico#7979 * Schedule calico-typha on master nodes
/sem-approve |
@lwr20 @coutinhop anything else we need from this prior to merge? The one thing I can see is that tests are failing - @ffilippopoulos you need to run |
I don't think so, @lwr20 please correct me if I'm wrong. |
/sem-approve |
…elease-v3.26 [release-v3.26] Auto pick #7979: Typha tolerate
…elease-v3.25 [release-v3.25] Auto pick #7979: Typha tolerate
…elease-v3.24 [release-v3.24] Auto pick #7979: Typha tolerate
… check (#551) * Clarify requirements for opened TCP ports * Major rework in network connectivity checks 1. Clarified listened and target ports for each node role. 2. Added UDP ports check (53 CoreDNS) 3. Connect each to each node. 4. Do not skip check if some node does not have python, or some ports are already listened. 5. Make connection attempts in parallel. 6. Only connect to listened ports or container ports instead of sending random stream of bytes. * Implement checking connectivity to VRRP IP * Update Installation.md * Fix floating issue at port listeners startup If the process is exited just after first failed attempt to read from pipe, the output is not checked and the connectivity check is terminated with error. The solution is to check if the process is exited first. * Calico Typha can be deployed on control planes projectcalico/calico#7979 --------- Co-authored-by: Shoaib Mohammed <[email protected]>
Description
Allow typha deployment to tolerate the taint set via kubelet when used with --cloud-provider=external flag. We need typha to be able to schedule as soon as possible on new nodes since calico-node relies on it.
Related issues/PRs
Related Slack thread:
https://calicousers.slack.com/archives/C0BCA117T/p1693469918340899
Todos
Someone should run the respective make target to generate manifests picking up this change.
Release Note