-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-v3.26] Manual pick #8827: Improve cni-plugin binary install verification #8842
[release-v3.26] Manual pick #8827: Improve cni-plugin binary install verification #8842
Conversation
Verify all installed binaries to make sure they were copied correctly.
/cc @coutinhop |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/sem-approve
/sem-approve |
There is 1 failure in the cni-plugin tests:
This looks more like a flake. There is also 1 error in the After pipeline jobs (
None of these failures seem to be related to this PR. Can we retrigger the checks? |
I believe that was a flake recently fixed in this PR: #8798 I'll get that one cherry-picked back, but shouldn't impact this pick. |
Cherry pick of #8827 on release-v3.26.
#8827: Improve cni-plugin binary install verification
Description
Related issues/PRs
Todos
Release Note
Reminder for the reviewer
Make sure that this PR has the correct labels and milestone set.
Every PR needs one
docs-*
label.docs-pr-required
: This change requires a change to the documentation that has not been completed yet.docs-completed
: This change has all necessary documentation completed.docs-not-required
: This change has no user-facing impact and requires no docs.Every PR needs one
release-note-*
label.release-note-required
: This PR has user-facing changes. Most PRs should have this label.release-note-not-required
: This PR has no user-facing changes.Other optional labels:
cherry-pick-candidate
: This PR should be cherry-picked to an earlier release. For bug fixes only.needs-operator-pr
: This PR is related to install and requires a corresponding change to the operator.