Enable necessary sysctls in the container and host net namespace for IPv6 #380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixes #345 |
gunjan5
force-pushed
the
ipv6awesomeness
branch
from
e44b568
to
11db86d
Compare
|
@caseydavenport updated the PR as per our discussion. PTAL |
utils/network.go
Outdated
| // Without these sysctls enabled, interfaces will come up but they won't get a link local IPv6 address | ||
| // which is required to add the default IPv6 route. | ||
| if err = writeProcSys("/proc/sys/net/ipv6/conf/all/disable_ipv6", "0"); err != nil { | ||
| return err |
There was a problem hiding this comment.
Will this error be descriptive enough?
I think we should wrap all of these so there's more context.
return fmt.Errorf("failed to set conf/all/disable_ipv6=0: %s", err)
There was a problem hiding this comment.
I've updated all the sysctl errors. I used the syntax used for working on sysctl commands so it's more user-friendly.
utils/network.go
Outdated
| @@ -258,6 +273,12 @@ func configureSysctls(hostVethName string, hasIPv4, hasIPv6 bool) error { | |||
| } | |||
|
|
|||
| if hasIPv6 { | |||
| // Make sure ipv6 is enabled on the hostVeth interface in the host network namespace. | |||
| // Interfaces won't get a linc local address without this sysctl set to 0. | |||
caseydavenport
approved these changes
Sep 18, 2017
gunjan5
force-pushed
the
ipv6awesomeness
branch
4 times, most recently
from
a159f95
to
1576232
Compare
caseydavenport
approved these changes
Sep 24, 2017
gunjan5
force-pushed
the
ipv6awesomeness
branch
2 times, most recently
from
a91f868
to
5aefc3e
Compare
…IPv6 to work remove invalid old test
gunjan5
force-pushed
the
ipv6awesomeness
branch
from
7680422
to
239c1b9
Compare
gunjan5
commented
Sep 24, 2017
|
|
||
| By("Manually programming the route that CNI plugin is going to add.") | ||
| netlink.RouteAdd( | ||
| &netlink.Route{ |
There was a problem hiding this comment.
@caseydavenport I'm removing this whole test (unrelated to this PR) because you can't add a route without the interface being present first which is why this test was failing. There's no easy way to reproduce the interface and route being present before we call CNI ADD, so I'm removing this test for now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add support for IPv6. This PR should make Calico work with kubernetes in IPv6
Todos
Release Note