Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(form): add question for static content #396

Merged
merged 3 commits into from
Apr 29, 2019

Conversation

czosel
Copy link
Contributor

@czosel czosel commented Apr 28, 2019

This adds a question type that can be used for inserting static content
like subheadings, additional text, images, videos, links etc. inside
forms (it will be rendered as markdown in the frontend).
Since it is not an actual question, no corresponding answer type
is required.

czosel added a commit to czosel/ember-caluma that referenced this pull request Apr 28, 2019
czosel added a commit to czosel/ember-caluma that referenced this pull request Apr 28, 2019
This adds a question type that can be used for inserting static content
like subheadings, additional text, images, videos, links etc. inside
forms (it will be rendered as markdown in the frontend).
Since it is not an actual question, no corresponding answer type
is required.
@czosel czosel force-pushed the add-static-question branch 2 times, most recently from d49ae3f to 912d9fc Compare April 29, 2019 09:16
Copy link
Contributor

@winged winged left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nitpick, otherwise LGTM

@@ -235,6 +241,8 @@ class Meta:
"row_form",
"sub_form",
"placeholder",
"static_content",
"static_content",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should only be listed once

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find, fixed!

@czosel czosel merged commit 56e4687 into projectcaluma:master Apr 29, 2019
@czosel czosel deleted the add-static-question branch April 29, 2019 13:18
czosel added a commit to projectcaluma/ember-caluma that referenced this pull request Apr 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants