-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(form): add question for static content #396
Conversation
This implements support for projectcaluma/caluma#396
This implements support for projectcaluma/caluma#396
c73b6fa
to
c7564de
Compare
This adds a question type that can be used for inserting static content like subheadings, additional text, images, videos, links etc. inside forms (it will be rendered as markdown in the frontend). Since it is not an actual question, no corresponding answer type is required.
c7564de
to
d7488f5
Compare
d49ae3f
to
912d9fc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor nitpick, otherwise LGTM
caluma/form/schema.py
Outdated
@@ -235,6 +241,8 @@ class Meta: | |||
"row_form", | |||
"sub_form", | |||
"placeholder", | |||
"static_content", | |||
"static_content", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should only be listed once
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice find, fixed!
912d9fc
to
e59584b
Compare
This implements support for projectcaluma/caluma#396
This adds a question type that can be used for inserting static content
like subheadings, additional text, images, videos, links etc. inside
forms (it will be rendered as markdown in the frontend).
Since it is not an actual question, no corresponding answer type
is required.