-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(license): switch main license to GPL-3.0-or-later #767
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
Just one suggestion: Instead of a short summary in the README, consider putting the main reasons for the choice, or a reference/link to the issue where it was discussed (#751).
BREAKING_CHANGE: switch main license to GPL-3.0-or-later
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Looks good, there's only one unanswered question: what exact license are we using for the frontend packages? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The notation is a bit confusing, we should decide which one of those we use:
- GPL-3.0-or-later
- GPLv3+
- GPL-3.0
@anehx GPL-3.0-or-later is the only correct one. Its the official SPDX identifier. I can't change that pypi doesn't use the correct one and that the license text itself isn't consistent. I changed the badge, though. Let me know if I missed an occurrence. |
And GitHub does everything wrong, when it comes to licenses:
Many people opened issues, for some reason, they don't want to fix the problem. |
Based on the discussion in issue #751, we reevaluated our goals. We want
We found that the definitions in AGPL aren't as clearcut as we wished; therefore, we want to switch to GPL-3.0-or-later. GPL will support all of our goals, with a minor draw-back: Not every last modification is guaranteed to end up in public. Which isn't that bad and it resolves all discussion about configuration.