feat(emeisOptions): enable action button label overrides

projectcaluma · Jun 28, 2022 · beca9f3 · beca9f3
1 parent 7fbc027
commit beca9f3
Show file tree

Hide file tree

Showing 4 changed files with 32 additions and 15 deletions.
diff --git a/README.md b/README.md
@@ -101,7 +101,10 @@ export default class EmeisOptionsService extends Service {
     */
     actions: {
       deactivate: (model) => myUser.canChange(model),
-      delete: (model) => myUser.canDelete(model),
+      delete: {
+        label: "some.translation.key", // you can optionally override the label for the action button with translation key or static string
+        fn: (model) => myUser.canDelete(model), // in case of label overrides, you have to define th function override via the "fn" key
+      },
     },
     // show only a subset of the "additional" fields on the user model
     additionalFields: {

diff --git a/addon/components/edit-form.hbs b/addon/components/edit-form.hbs
@@ -22,7 +22,7 @@
         data-test-toggle-active
         @onClick={{perform this.toggleActiveState}}
       >
-        {{t (concat "emeis.form." (if @model.isActive "deactivate" "activate"))}}
+        {{or (optional-translate this.deactivateLabelOverride) (t (concat "emeis.form." (if @model.isActive "deactivate" "activate")))}}
       </UkButton>
     {{/if}}
 
@@ -34,7 +34,7 @@
         data-test-delete
         @onClick={{perform this.delete}}
       >
-        {{t "emeis.form.delete"}}
+        {{or (optional-translate this.deleteLabelOverride) (t "emeis.form.delete")}}
       </UkButton>
     {{/if}}
 

diff --git a/addon/components/edit-form.js b/addon/components/edit-form.js
@@ -55,21 +55,32 @@ export default class EditFormComponent extends Component {
   }
 
   get canChangeActiveState() {
-    return this.emeisOptions[this.args.model?._internalModel?.modelName]
-      ?.actions?.deactivate
-      ? this.emeisOptions[
-          this.args.model._internalModel.modelName
-        ]?.actions?.deactivate(this.args.model)
-      : true;
+    const deactivateOption =
+      this.emeisOptions[this.args.model?._internalModel?.modelName]?.actions
+        ?.deactivate?.fn;
+    const deactivate =
+      typeof deactivateOption === "function"
+        ? deactivateOption
+        : deactivateOption?.fn;
+    return deactivate ? deactivate(this.args.model) : true;
   }
 
   get canDeleteModel() {
+    const delOption =
+      this.emeisOptions[this.args.model?._internalModel?.modelName]?.actions
+        ?.delete;
+    const del = typeof delOption === "function" ? delOption : delOption?.fn;
+    return del ? del(this.args.model) : true;
+  }
+
+  get deactivateLabelOverride() {
+    return this.emeisOptions[this.args.model?._internalModel?.modelName]
+      ?.actions?.deactivate?.label;
+  }
+
+  get deleteLabelOverride() {
     return this.emeisOptions[this.args.model?._internalModel?.modelName]
-      ?.actions?.delete
-      ? this.emeisOptions[
-          this.args.model._internalModel.modelName
-        ]?.actions?.delete(this.args.model)
-      : true;
+      ?.actions?.delete?.label;
   }
 
   @task

diff --git a/tests/dummy/app/services/emeis-options.js b/tests/dummy/app/services/emeis-options.js
@@ -54,7 +54,10 @@ export default class EmeisOptionsService extends Service {
   // scope view specific settings
   scope = {
     actions: {
-      delete: (model) => model.id !== "special",
+      delete: {
+        label: "my delete label",
+        fn: (model) => model.id !== "special",
+      },
       deactivate: (model) => model.id !== "special",
     },
     metaFields: [