Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: error handling decorator for ember-concurrency tasks #386

Merged
merged 1 commit into from
Jan 27, 2022

Conversation

czosel
Copy link
Contributor

@czosel czosel commented Jan 25, 2022

No description provided.

Copy link
Contributor

@anehx anehx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but where is the test?

@czosel czosel force-pushed the fix-model-error-decorator branch 2 times, most recently from 6149479 to bec1a56 Compare January 27, 2022 16:48
@czosel
Copy link
Contributor Author

czosel commented Jan 27, 2022

Added a test 🌟

@derrabauke derrabauke merged commit 63b8704 into main Jan 27, 2022
@czosel czosel deleted the fix-model-error-decorator branch January 27, 2022 18:38
github-actions bot pushed a commit that referenced this pull request Jan 27, 2022
## [3.1.1](v3.1.0...v3.1.1) (2022-01-27)

### Bug Fixes

* don't fetch ACLs when user doesn't exist yet ([#385](#385)) ([b407b5e](b407b5e))
* error handling decorator for ember-concurrency tasks ([#386](#386)) ([63b8704](63b8704))
* tree control search and expansion ([#387](#387)) ([98adf1c](98adf1c))
* use full-name in parent scope selection ([#389](#389)) ([f54d27a](f54d27a))
* use intl translation ([#394](#394)) ([2bb4942](2bb4942))
@czosel
Copy link
Contributor Author

czosel commented Jan 27, 2022

🎉 This PR is included in version 3.1.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants