Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(deps): upgrade mirage #388

Merged
merged 6 commits into from
Jan 26, 2022
Merged

chore(deps): upgrade mirage #388

merged 6 commits into from
Jan 26, 2022

Conversation

derrabauke
Copy link
Contributor

  • substitutes faker.js with new @faker/faker-js
  • change old imports from ember-cli-mirage to miragejs
  • fix pipeline via resolutions for @embroider/macros

@derrabauke derrabauke force-pushed the bump-mirage-to-2.4.0 branch 2 times, most recently from e9cf339 to 3c327f6 Compare January 26, 2022 13:58
@derrabauke
Copy link
Contributor Author

@renderInPlace={{true}} on the ember-power-select fixes an issue with the in-element helper of ember-basic-dropdown
The error was:

Error: Assertion Failed: You cannot pass a null or undefined destination element to in-element

czosel
czosel approved these changes Jan 26, 2022
View reviewed changes
Copy link
Contributor

@czosel czosel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@czosel czosel merged commit 3884c5e into projectcaluma:main Jan 26, 2022
@derrabauke derrabauke deleted the bump-mirage-to-2.4.0 branch January 27, 2022 09:14
@czosel
Copy link
Contributor

czosel commented Jan 27, 2022

🎉 This PR is included in version 3.1.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@velrest velrest mentioned this pull request Jan 25, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@czosel czosel czosel approved these changes

@anehx anehx Awaiting requested review from anehx

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@derrabauke @czosel