Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(translations): consistent warning msg for user deletion #422

Merged
merged 1 commit into from
Feb 23, 2022

Conversation

czosel
Copy link
Contributor

@czosel czosel commented Feb 23, 2022

Because of the generic way EditForm is implemented, we currently show
a generic warning message when a user is deleted from the detail view.
This uses the same warning when a user is deleted from the list view
(for consistency).

Because of the generic way `EditForm` is implemented, we currently show
a generic warning message when a user is deleted from the detail view.
This uses the same warning when a user is deleted from the list view
(for consistency).
Copy link
Contributor

@derrabauke derrabauke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🪨

@czosel czosel merged commit 7f27ae3 into projectcaluma:main Feb 23, 2022
github-actions bot pushed a commit that referenced this pull request Feb 23, 2022
## [4.2.1](v4.2.0...v4.2.1) (2022-02-23)

### Bug Fixes

* **translations:** consistent warning msg for user deletion ([#422](#422)) ([7f27ae3](7f27ae3))
@czosel
Copy link
Contributor Author

czosel commented Feb 23, 2022

🎉 This PR is included in version 4.2.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

derrabauke pushed a commit to derrabauke/ember-emeis that referenced this pull request Apr 14, 2022
…aluma#422)

Because of the generic way `EditForm` is implemented, we currently show
a generic warning message when a user is deleted from the detail view.
This uses the same warning when a user is deleted from the list view
(for consistency).
derrabauke pushed a commit to derrabauke/ember-emeis that referenced this pull request Apr 14, 2022
## [4.2.1](projectcaluma/ember-emeis@v4.2.0...v4.2.1) (2022-02-23)

### Bug Fixes

* **translations:** consistent warning msg for user deletion ([projectcaluma#422](projectcaluma#422)) ([7f27ae3](projectcaluma@7f27ae3))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants