Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test failing with latest gateway-api conformance suite #4543

Closed
tsaarni opened this issue May 20, 2022 · 2 comments
Closed

Test failing with latest gateway-api conformance suite #4543

tsaarni opened this issue May 20, 2022 · 2 comments
Assignees
@skriss
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@tsaarni
Copy link
Member

tsaarni commented May 20, 2022

CI got broken after some of the recent changes in gateway-api conformance test suite. Following error now happens consistently e.g. https://github.com/projectcontour/contour/runs/6525677808?check_suite_focus=true#step:7:426

        httproute-invalid-reference-policy.go:93: 
            	Error Trace:	helpers.go:243
            	            				helpers.go:140
            	            				httproute-invalid-reference-policy.go:93
            	            				suite.go:185
            	            				suite.go:140
            	Error:      	Received unexpected error:
            	            	timed out waiting for the condition
            	Test:       	TestConformance/HTTPRouteInvalidReferencePolicy
            	Messages:   	error waiting for HTTPRoute to have parents matching expectations
@tsaarni tsaarni added kind/bug Categorizes issue or PR as related to a bug. lifecycle/needs-triage Indicates that an issue needs to be triaged by a project contributor. labels May 20, 2022
@skriss skriss self-assigned this May 20, 2022
@skriss skriss removed the lifecycle/needs-triage Indicates that an issue needs to be triaged by a project contributor. label May 20, 2022
@skriss
Copy link
Member

skriss commented May 20, 2022

I'm taking a look at this, looks like a combo of a fun upstream change and something we now need to update in Contour:

skriss added a commit to skriss/contour that referenced this issue May 20, 2022
@skriss
Gateway API: return a 404 when no valid backend refs
cc1adaa 
The Gateway API spec has been updated to
require returning a 404 instead of a 503
when there are no valid backend refs on
an HTTPRoute rule. Updates Contour to match
the revised spec.

Updates projectcontour#4543.

Signed-off-by: Steve Kriss <[email protected]>
@skriss skriss mentioned this issue May 20, 2022
Merged
skriss added a commit that referenced this issue May 20, 2022
@skriss
Gateway API: return a 404 when no valid backend refs (#4545)
313f38a 
The Gateway API spec has been updated to
require returning a 404 instead of a 503
when there are no valid backend refs on
an HTTPRoute rule. Updates Contour to match
the revised spec & conformance test.

Updates #4543.

Signed-off-by: Steve Kriss <[email protected]>
@skriss
Copy link
Member

skriss commented May 24, 2022

Upstream PR has been merged and we're back to green: https://github.com/projectcontour/contour/runs/6565697126?check_suite_focus=true

@skriss skriss closed this as completed May 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@skriss skriss

Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tsaarni @skriss