Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DynamicVar incorrect parsing on bool values #150

Closed
RamanaReddy0M opened this issue Oct 25, 2023 · 0 comments · Fixed by #151
Closed

DynamicVar incorrect parsing on bool values #150

RamanaReddy0M opened this issue Oct 25, 2023 · 0 comments · Fixed by #151
Assignees
@RamanaReddy0M
Labels
Status: Completed Nothing further to be done with this issue. Awaiting to be closed. Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors.

Comments

@RamanaReddy0M
Copy link
Contributor

when we pass t,f,true,false,0,1 as dynamic flag values, always returns default value.

ex:

...
flagset.DynamicVar(&options.hasPoc, "poc", "true", "display cves that has public published poc"),
...
$ go run . -poc=false  # hasPoc = true
$ go run . -poc #haPoc=true

expected:

$ go run . -poc=false  # hasPoc = false
$ go run . -poc # haPoc=true
@RamanaReddy0M RamanaReddy0M self-assigned this Oct 25, 2023
@RamanaReddy0M RamanaReddy0M linked a pull request Oct 25, 2023 that will close this issue
Fix dynamicvar incorrect parsing on bool values #151
Merged
@RamanaReddy0M RamanaReddy0M mentioned this issue Oct 25, 2023
Merged
@RamanaReddy0M RamanaReddy0M added the Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors. label Nov 2, 2023
@ehsandeep ehsandeep added the Status: Completed Nothing further to be done with this issue. Awaiting to be closed. label Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@RamanaReddy0M RamanaReddy0M

Labels
Status: Completed Nothing further to be done with this issue. Awaiting to be closed. Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix dynamicvar incorrect parsing on bool values projectdiscovery/goflags
2 participants
@ehsandeep @RamanaReddy0M