Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix dynamicvar incorrect parsing on bool values #151

Merged
merged 2 commits into from
Nov 2, 2023
Merged

Fix dynamicvar incorrect parsing on bool values #151

merged 2 commits into from
Nov 2, 2023

Conversation

RamanaReddy0M
Copy link
Contributor

@RamanaReddy0M RamanaReddy0M commented Oct 25, 2023 •
edited
Loading

@RamanaReddy0M RamanaReddy0M self-assigned this Oct 25, 2023
@RamanaReddy0M RamanaReddy0M linked an issue Oct 25, 2023 that may be closed by this pull request
DynamicVar incorrect parsing on bool values #150
Closed
@RamanaReddy0M RamanaReddy0M mentioned this pull request Oct 25, 2023
Merged
dogancanbakir
dogancanbakir requested changes Oct 25, 2023
View reviewed changes
dynamic_var.go Show resolved Hide resolved
dynamic_var.go Show resolved Hide resolved
dogancanbakir
dogancanbakir approved these changes Nov 2, 2023
View reviewed changes
Copy link
Member

@dogancanbakir dogancanbakir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ehsandeep ehsandeep merged commit a9d5d68 into main Nov 2, 2023
5 checks passed
@ehsandeep ehsandeep deleted the issue-150-dynamicvar branch November 2, 2023 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ehsandeep ehsandeep ehsandeep approved these changes

@dogancanbakir dogancanbakir dogancanbakir approved these changes

Assignees

@RamanaReddy0M RamanaReddy0M

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DynamicVar incorrect parsing on bool values
3 participants
@RamanaReddy0M @ehsandeep @dogancanbakir