-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use std config directories #4228
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Flow of migration
check old config directory$ la ~/.config/nuclei | wc
64 569 4862 migrationany first command executed with new nuclei will attempt to migrate and it will only happens once. in this case we print $ ./nuclei -version
[INF] Nuclei Engine Version: v3.0.0-dev
[INF] Nuclei Config Directory: /Users/tarun/Library/Application Support/nuclei
[INF] Nuclei Cache Directory: /Users/tarun/Library/Caches/nuclei Now migration has successfully completed atomic deletion of old config directory$ la ~/.config/nuclei | wc
ls: /Users/tarun/.config/nuclei: No such file or directory
0 0 0
Configs moved to platform specific config directory$ la ~/Library/Application\ Support/nuclei | wc
9 74 540 Resume files moved to platform specific cache directory$ la ~/Library/Caches/nuclei | wc
55 488 4277 |
TODO
|
ehsandeep
approved these changes
Oct 11, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Additional domain for TrustedTemplateDomain
=> cloud.projectdiscovery.io
Mzack9999
approved these changes
Oct 12, 2023
ehsandeep
approved these changes
Oct 13, 2023
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
nuclei
fails to start when~/.config
is not writable #3576config directory
tocache directory
(both of them are platform/env specific)-version
flag prints config folders as they are platform specific`Checklist